Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct parameter key in ECS target in aws_pipes_pipe #32432

Merged
merged 3 commits into from
Jul 17, 2023
Merged

use correct parameter key in ECS target in aws_pipes_pipe #32432

merged 3 commits into from
Jul 17, 2023

Conversation

NixM0nk3y
Copy link

Description

Recently introduced aws_pipes_pipe source/target enhancements have a typo in the in the ecs task target provider leading to errors when attempting to provision a pipe using ecs as a target:

aws_pipes_pipe.event_process_pipe: Creating...
aws_pipes_pipe.event_process_pipe: Still creating... [10s elapsed]
╷
│ Error: setting target_parameters: Invalid address to set: []string{"target_parameters", "0", "cloudwatch_logs_parameters", "0", "task_definition_arn"}
│ 
│   with aws_pipes_pipe.event_process_pipe,
│   on pipes.tf line 73, in resource "aws_pipes_pipe" "event_process_pipe":
│   73: resource "aws_pipes_pipe" "event_process_pipe" {
│ 

Relations

Relates #31607

Output from Acceptance Testing

$ make testacc PKG=pipes TESTS=TestAccPipesPipe_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/pipes/... -v -count 1 -parallel 20 -run='TestAccPipesPipe_'  -timeout 180m
=== RUN   TestAccPipesPipe_basicSQS
=== PAUSE TestAccPipesPipe_basicSQS
=== RUN   TestAccPipesPipe_disappears
=== PAUSE TestAccPipesPipe_disappears
=== RUN   TestAccPipesPipe_description
=== PAUSE TestAccPipesPipe_description
=== RUN   TestAccPipesPipe_desiredState
=== PAUSE TestAccPipesPipe_desiredState
=== RUN   TestAccPipesPipe_enrichment
=== PAUSE TestAccPipesPipe_enrichment
=== RUN   TestAccPipesPipe_enrichmentParameters
=== PAUSE TestAccPipesPipe_enrichmentParameters
=== RUN   TestAccPipesPipe_sourceParameters_filterCriteria
=== PAUSE TestAccPipesPipe_sourceParameters_filterCriteria
=== RUN   TestAccPipesPipe_nameGenerated
=== PAUSE TestAccPipesPipe_nameGenerated
=== RUN   TestAccPipesPipe_namePrefix
=== PAUSE TestAccPipesPipe_namePrefix
=== RUN   TestAccPipesPipe_roleARN
=== PAUSE TestAccPipesPipe_roleARN
=== RUN   TestAccPipesPipe_tags
=== PAUSE TestAccPipesPipe_tags
=== RUN   TestAccPipesPipe_targetUpdate
=== PAUSE TestAccPipesPipe_targetUpdate
=== RUN   TestAccPipesPipe_targetParameters_inputTemplate
=== PAUSE TestAccPipesPipe_targetParameters_inputTemplate
=== RUN   TestAccPipesPipe_kinesisSourceAndTarget
=== PAUSE TestAccPipesPipe_kinesisSourceAndTarget
=== RUN   TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget
=== PAUSE TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget
=== RUN   TestAccPipesPipe_activeMQSourceStepFunctionTarget
=== PAUSE TestAccPipesPipe_activeMQSourceStepFunctionTarget
=== RUN   TestAccPipesPipe_rabbitMQSourceEventBusTarget
=== PAUSE TestAccPipesPipe_rabbitMQSourceEventBusTarget
=== RUN   TestAccPipesPipe_mskSourceHTTPTarget
    acctest.go:82: DependencyViolation errors deleting subnets and security group
--- SKIP: TestAccPipesPipe_mskSourceHTTPTarget (0.00s)
=== RUN   TestAccPipesPipe_selfManagedKafkaSourceLambdaFunctionTarget
    acctest.go:82: DependencyViolation errors deleting subnets and security group
--- SKIP: TestAccPipesPipe_selfManagedKafkaSourceLambdaFunctionTarget (0.00s)
=== RUN   TestAccPipesPipe_sqsSourceRedshiftTarget
=== PAUSE TestAccPipesPipe_sqsSourceRedshiftTarget
=== RUN   TestAccPipesPipe_SourceSageMakerTarget
    acctest.go:82: aws_sagemaker_pipeline resource not yet implemented
--- SKIP: TestAccPipesPipe_SourceSageMakerTarget (0.00s)
=== RUN   TestAccPipesPipe_sqsSourceBatchJobTarget
=== PAUSE TestAccPipesPipe_sqsSourceBatchJobTarget
=== RUN   TestAccPipesPipe_sqsSourceECSTaskTarget
    acctest.go:82: ValidationException: [numeric instance is lower than the required minimum (minimum: 1, found: 0)]
--- SKIP: TestAccPipesPipe_sqsSourceECSTaskTarget (0.00s)
=== CONT  TestAccPipesPipe_basicSQS
=== CONT  TestAccPipesPipe_tags
=== CONT  TestAccPipesPipe_rabbitMQSourceEventBusTarget
=== CONT  TestAccPipesPipe_nameGenerated
=== CONT  TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget
=== CONT  TestAccPipesPipe_kinesisSourceAndTarget
=== CONT  TestAccPipesPipe_roleARN
=== CONT  TestAccPipesPipe_namePrefix
=== CONT  TestAccPipesPipe_sourceParameters_filterCriteria
=== CONT  TestAccPipesPipe_activeMQSourceStepFunctionTarget
=== CONT  TestAccPipesPipe_sqsSourceBatchJobTarget
=== CONT  TestAccPipesPipe_sqsSourceRedshiftTarget
=== CONT  TestAccPipesPipe_enrichmentParameters
=== CONT  TestAccPipesPipe_targetParameters_inputTemplate
=== CONT  TestAccPipesPipe_targetUpdate
=== CONT  TestAccPipesPipe_desiredState
=== CONT  TestAccPipesPipe_description
=== CONT  TestAccPipesPipe_enrichment
=== CONT  TestAccPipesPipe_disappears
--- PASS: TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget (92.46s)
--- PASS: TestAccPipesPipe_kinesisSourceAndTarget (98.75s)
--- PASS: TestAccPipesPipe_disappears (114.52s)
--- PASS: TestAccPipesPipe_namePrefix (121.62s)
--- PASS: TestAccPipesPipe_nameGenerated (121.64s)
--- PASS: TestAccPipesPipe_basicSQS (133.45s)
--- PASS: TestAccPipesPipe_enrichmentParameters (170.44s)
--- PASS: TestAccPipesPipe_roleARN (172.50s)
--- PASS: TestAccPipesPipe_tags (188.07s)
--- PASS: TestAccPipesPipe_sqsSourceBatchJobTarget (195.51s)
--- PASS: TestAccPipesPipe_targetParameters_inputTemplate (199.87s)
--- PASS: TestAccPipesPipe_targetUpdate (214.41s)
--- PASS: TestAccPipesPipe_enrichment (226.59s)
--- PASS: TestAccPipesPipe_desiredState (239.83s)
--- PASS: TestAccPipesPipe_description (271.00s)
--- PASS: TestAccPipesPipe_sqsSourceRedshiftTarget (301.94s)
--- PASS: TestAccPipesPipe_sourceParameters_filterCriteria (317.94s)
--- PASS: TestAccPipesPipe_rabbitMQSourceEventBusTarget (896.23s)
--- PASS: TestAccPipesPipe_activeMQSourceStepFunctionTarget (1129.08s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/pipes      1129.164s

@github-actions
Copy link

github-actions bot commented Jul 9, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/pipes Issues and PRs that pertain to the pipes service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jul 9, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @NixM0nk3y 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 10, 2023
@johnsonaj johnsonaj self-assigned this Jul 17, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc PKG=pipes TESTS=TestAccPipesPipe_

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/pipes/... -v -count 1 -parallel 20 -run='TestAccPipesPipe_'  -timeout 180m
    acctest.go:82: DependencyViolation errors deleting subnets and security group
--- SKIP: TestAccPipesPipe_mskSourceHTTPTarget (0.00s)
    acctest.go:82: DependencyViolation errors deleting subnets and security group
--- SKIP: TestAccPipesPipe_selfManagedKafkaSourceLambdaFunctionTarget (0.00s)
    acctest.go:82: aws_sagemaker_pipeline resource not yet implemented
--- SKIP: TestAccPipesPipe_SourceSageMakerTarget (0.00s)
    acctest.go:82: ValidationException: [numeric instance is lower than the required minimum (minimum: 1, found: 0)]
--- SKIP: TestAccPipesPipe_sqsSourceECSTaskTarget (0.00s)
--- PASS: TestAccPipesPipe_kinesisSourceAndTarget (85.23s)
--- PASS: TestAccPipesPipe_disappears (101.85s)
--- PASS: TestAccPipesPipe_dynamoDBSourceCloudWatchLogsTarget (102.90s)
--- PASS: TestAccPipesPipe_namePrefix (121.23s)
--- PASS: TestAccPipesPipe_basicSQS (126.98s)
--- PASS: TestAccPipesPipe_nameGenerated (127.03s)
--- PASS: TestAccPipesPipe_tags (153.29s)
--- PASS: TestAccPipesPipe_enrichmentParameters (154.73s)
--- PASS: TestAccPipesPipe_roleARN (167.77s)
--- PASS: TestAccPipesPipe_enrichment (175.12s)
--- PASS: TestAccPipesPipe_targetUpdate (183.10s)
--- PASS: TestAccPipesPipe_targetParameters_inputTemplate (183.69s)
--- PASS: TestAccPipesPipe_sqsSourceBatchJobTarget (185.07s)
--- PASS: TestAccPipesPipe_desiredState (198.45s)
--- PASS: TestAccPipesPipe_description (227.72s)
--- PASS: TestAccPipesPipe_sourceParameters_filterCriteria (267.19s)
--- PASS: TestAccPipesPipe_sqsSourceRedshiftTarget (361.43s)
--- PASS: TestAccPipesPipe_rabbitMQSourceEventBusTarget (682.37s)
--- PASS: TestAccPipesPipe_activeMQSourceStepFunctionTarget (1108.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/pipes	1112.132s

@johnsonaj
Copy link
Contributor

Thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 3653b7e into hashicorp:main Jul 17, 2023
37 checks passed
@github-actions github-actions bot added this to the v5.9.0 milestone Jul 17, 2023
@github-actions
Copy link

This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/pipes Issues and PRs that pertain to the pipes service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants