Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Migrate internetmonitor resources to AWS SDK for Go v2 #32343

Merged
merged 13 commits into from
Jul 3, 2023

Conversation

ewbankkit
Copy link
Contributor

Description

Also adds the health_events_config configuration block.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccInternetMonitorMonitor_' PKG=internetmonitor ACCTEST_PARALLELISM=2 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/internetmonitor/... -v -count 1 -parallel 2  -run=TestAccInternetMonitorMonitor_ -timeout 180m
=== RUN   TestAccInternetMonitorMonitor_basic
=== PAUSE TestAccInternetMonitorMonitor_basic
=== RUN   TestAccInternetMonitorMonitor_disappears
=== PAUSE TestAccInternetMonitorMonitor_disappears
=== RUN   TestAccInternetMonitorMonitor_tags
=== PAUSE TestAccInternetMonitorMonitor_tags
=== RUN   TestAccInternetMonitorMonitor_healthEventsConfig
=== PAUSE TestAccInternetMonitorMonitor_healthEventsConfig
=== RUN   TestAccInternetMonitorMonitor_log
=== PAUSE TestAccInternetMonitorMonitor_log
=== CONT  TestAccInternetMonitorMonitor_basic
=== CONT  TestAccInternetMonitorMonitor_healthEventsConfig
--- PASS: TestAccInternetMonitorMonitor_healthEventsConfig (70.87s)
=== CONT  TestAccInternetMonitorMonitor_log
--- PASS: TestAccInternetMonitorMonitor_basic (70.89s)
=== CONT  TestAccInternetMonitorMonitor_tags
--- PASS: TestAccInternetMonitorMonitor_log (55.52s)
=== CONT  TestAccInternetMonitorMonitor_disappears
--- PASS: TestAccInternetMonitorMonitor_tags (81.96s)
--- PASS: TestAccInternetMonitorMonitor_disappears (39.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/internetmonitor	170.458s
% make sweep SWEEPARGS=-sweep-run=aws_internetmonitor_monitor
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2 -sweep-run=aws_internetmonitor_monitor -timeout 60m
2023/07/01 18:23:19 [DEBUG] Running Sweepers for region (us-west-2):
2023/07/01 18:23:19 [DEBUG] Running Sweeper (aws_internetmonitor_monitor) in region (us-west-2)
2023/07/01 18:23:20 [DEBUG] Completed Sweeper (aws_internetmonitor_monitor) in region (us-west-2) in 1.283620139s
2023/07/01 18:23:20 Completed Sweepers for region (us-west-2) in 1.283854278s
2023/07/01 18:23:20 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_internetmonitor_monitor
2023/07/01 18:23:20 [DEBUG] Running Sweepers for region (us-east-1):
2023/07/01 18:23:20 [DEBUG] Running Sweeper (aws_internetmonitor_monitor) in region (us-east-1)
2023/07/01 18:23:21 [DEBUG] Completed Sweeper (aws_internetmonitor_monitor) in region (us-east-1) in 998.244205ms
2023/07/01 18:23:21 Completed Sweepers for region (us-east-1) in 998.304557ms
2023/07/01 18:23:21 Sweeper Tests for region (us-east-1) ran successfully:
	- aws_internetmonitor_monitor
2023/07/01 18:23:21 [DEBUG] Running Sweepers for region (us-east-2):
2023/07/01 18:23:21 [DEBUG] Running Sweeper (aws_internetmonitor_monitor) in region (us-east-2)
2023/07/01 18:23:22 [DEBUG] Completed Sweeper (aws_internetmonitor_monitor) in region (us-east-2) in 527.014003ms
2023/07/01 18:23:22 Completed Sweepers for region (us-east-2) in 527.073672ms
2023/07/01 18:23:22 Sweeper Tests for region (us-east-2) ran successfully:
	- aws_internetmonitor_monitor
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	7.853s

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/internetmonitor Issues and PRs that pertain to the internetmonitor service. size/XL Managed by automation to categorize the size of a PR. labels Jul 3, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=internetmonitor TESTS=TestAccInternetMonitorMonitor_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/internetmonitor/... -v -count 1 -parallel 20 -run='TestAccInternetMonitorMonitor_'  -timeout 180m
=== RUN   TestAccInternetMonitorMonitor_basic
=== PAUSE TestAccInternetMonitorMonitor_basic
=== RUN   TestAccInternetMonitorMonitor_log
=== PAUSE TestAccInternetMonitorMonitor_log
=== RUN   TestAccInternetMonitorMonitor_disappears
=== PAUSE TestAccInternetMonitorMonitor_disappears
=== RUN   TestAccInternetMonitorMonitor_tags
=== PAUSE TestAccInternetMonitorMonitor_tags
=== CONT  TestAccInternetMonitorMonitor_basic
=== CONT  TestAccInternetMonitorMonitor_disappears
=== CONT  TestAccInternetMonitorMonitor_log
=== CONT  TestAccInternetMonitorMonitor_tags
--- PASS: TestAccInternetMonitorMonitor_log (44.93s)
--- PASS: TestAccInternetMonitorMonitor_disappears (47.92s)
--- PASS: TestAccInternetMonitorMonitor_basic (60.57s)
--- PASS: TestAccInternetMonitorMonitor_tags (155.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/internetmonitor    158.740s

@ewbankkit ewbankkit merged commit 3443f51 into main Jul 3, 2023
@ewbankkit ewbankkit deleted the td-migrate-internetmonitor-to-aws-sdk-v2 branch July 3, 2023 14:33
@github-actions github-actions bot added this to the v5.7.0 milestone Jul 3, 2023
github-actions bot pushed a commit that referenced this pull request Jul 3, 2023
@ewbankkit ewbankkit changed the title Tech debt: Migrate internermonitor resources to AWS SDK for Go v2 Tech debt: Migrate internetmonitor resources to AWS SDK for Go v2 Jul 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 7, 2023

This functionality has been released in v5.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/internetmonitor Issues and PRs that pertain to the internetmonitor service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants