-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tech debt: Migrate pricing
resources to AWS SDK for Go v2
#32135
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
$ make testacc PKG=pricing
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/pricing/... -v -count 1 -parallel 20 -timeout 180m
=== RUN TestAccPricingProductDataSource_ec2
=== PAUSE TestAccPricingProductDataSource_ec2
=== RUN TestAccPricingProductDataSource_redshift
=== PAUSE TestAccPricingProductDataSource_redshift
=== CONT TestAccPricingProductDataSource_ec2
=== CONT TestAccPricingProductDataSource_redshift
--- PASS: TestAccPricingProductDataSource_redshift (10.94s)
--- PASS: TestAccPricingProductDataSource_ec2 (10.98s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/pricing 14.394s
This functionality has been released in v5.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Ibid.
Output from Acceptance Testing