Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TechDebt: Migrate lightsail service to aws-go-sdk-v2 #31853

Merged
merged 84 commits into from
Jun 12, 2023
Merged

TechDebt: Migrate lightsail service to aws-go-sdk-v2 #31853

merged 84 commits into from
Jun 12, 2023

Conversation

brittandeyoung
Copy link
Collaborator

@brittandeyoung brittandeyoung commented Jun 8, 2023 •
edited
Loading

Description

This pull request upgrades the lightsail service to aws go sdk v2 and updates all resources to work with the new sdk.

Relations

Closes #0000

References

Output from Acceptance Testing


Bucket:
 make testacc TESTARGS='-run=TestAccLightsailBucket' PKG=lightsail      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailBucket -timeout 180m
=== RUN   TestAccLightsailBucketAccessKey_basic
=== PAUSE TestAccLightsailBucketAccessKey_basic
=== RUN   TestAccLightsailBucketAccessKey_disappears
=== PAUSE TestAccLightsailBucketAccessKey_disappears
=== RUN   TestAccLightsailBucketResourceAccess_basic
=== PAUSE TestAccLightsailBucketResourceAccess_basic
=== RUN   TestAccLightsailBucketResourceAccess_disappears
=== PAUSE TestAccLightsailBucketResourceAccess_disappears
=== RUN   TestAccLightsailBucket_basic
=== PAUSE TestAccLightsailBucket_basic
=== RUN   TestAccLightsailBucket_BundleId
=== PAUSE TestAccLightsailBucket_BundleId
=== RUN   TestAccLightsailBucket_disappears
=== PAUSE TestAccLightsailBucket_disappears
=== RUN   TestAccLightsailBucket_tags
=== PAUSE TestAccLightsailBucket_tags
=== CONT  TestAccLightsailBucketAccessKey_basic
=== CONT  TestAccLightsailBucket_basic
=== CONT  TestAccLightsailBucket_disappears
=== CONT  TestAccLightsailBucket_tags
=== CONT  TestAccLightsailBucket_BundleId
=== CONT  TestAccLightsailBucketResourceAccess_basic
=== CONT  TestAccLightsailBucketResourceAccess_disappears
=== CONT  TestAccLightsailBucketAccessKey_disappears
--- PASS: TestAccLightsailBucket_disappears (36.39s)
--- PASS: TestAccLightsailBucket_basic (45.06s)
--- PASS: TestAccLightsailBucketAccessKey_disappears (52.97s)
--- PASS: TestAccLightsailBucketAccessKey_basic (58.58s)
--- PASS: TestAccLightsailBucket_BundleId (64.90s)
--- PASS: TestAccLightsailBucket_tags (77.76s)
--- PASS: TestAccLightsailBucketResourceAccess_disappears (83.88s)
--- PASS: TestAccLightsailBucketResourceAccess_basic (88.25s)
PASS

Certificate:
make testacc TESTARGS='-run=TestAccLightsailCertificate' PKG=lightsail    
 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailCertificate -timeout 180m
=== RUN   TestAccLightsailCertificate_basic
=== PAUSE TestAccLightsailCertificate_basic
=== RUN   TestAccLightsailCertificate_subjectAlternativeNames
=== PAUSE TestAccLightsailCertificate_subjectAlternativeNames
=== RUN   TestAccLightsailCertificate_DomainValidationOptions
=== PAUSE TestAccLightsailCertificate_DomainValidationOptions
=== RUN   TestAccLightsailCertificate_tags
=== PAUSE TestAccLightsailCertificate_tags
=== RUN   TestAccLightsailCertificate_disappears
=== PAUSE TestAccLightsailCertificate_disappears
=== CONT  TestAccLightsailCertificate_basic
=== CONT  TestAccLightsailCertificate_tags
=== CONT  TestAccLightsailCertificate_subjectAlternativeNames
=== CONT  TestAccLightsailCertificate_disappears
=== CONT  TestAccLightsailCertificate_DomainValidationOptions
--- PASS: TestAccLightsailCertificate_disappears (65.53s)
--- PASS: TestAccLightsailCertificate_DomainValidationOptions (66.18s)
--- PASS: TestAccLightsailCertificate_subjectAlternativeNames (72.28s)
--- PASS: TestAccLightsailCertificate_basic (77.75s)
--- PASS: TestAccLightsailCertificate_tags (135.69s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  140.178s

Disk:
 make testacc TESTARGS='-run=TestAccLightsailDisk' PKG=lightsail       
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailDisk -timeout 180m
=== RUN   TestAccLightsailDiskAttachment_basic
=== PAUSE TestAccLightsailDiskAttachment_basic
=== RUN   TestAccLightsailDiskAttachment_disappears
=== PAUSE TestAccLightsailDiskAttachment_disappears
=== RUN   TestAccLightsailDisk_basic
=== PAUSE TestAccLightsailDisk_basic
=== RUN   TestAccLightsailDisk_Tags
=== PAUSE TestAccLightsailDisk_Tags
=== RUN   TestAccLightsailDisk_disappears
=== PAUSE TestAccLightsailDisk_disappears
=== CONT  TestAccLightsailDiskAttachment_basic
=== CONT  TestAccLightsailDisk_Tags
=== CONT  TestAccLightsailDisk_disappears
=== CONT  TestAccLightsailDisk_basic
=== CONT  TestAccLightsailDiskAttachment_disappears
--- PASS: TestAccLightsailDisk_disappears (49.83s)
--- PASS: TestAccLightsailDisk_basic (54.00s)
--- PASS: TestAccLightsailDisk_Tags (80.29s)
--- PASS: TestAccLightsailDiskAttachment_disappears (191.19s)
--- PASS: TestAccLightsailDiskAttachment_basic (197.24s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  200.406s

Domain:
 make testacc TESTARGS='-run=TestAccLightsailDomain' PKG=lightsail     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailDomain -timeout 180m
=== RUN   TestAccLightsailDomainEntry_basic
=== PAUSE TestAccLightsailDomainEntry_basic
=== RUN   TestAccLightsailDomainEntry_underscore
=== PAUSE TestAccLightsailDomainEntry_underscore
=== RUN   TestAccLightsailDomainEntry_apex
=== PAUSE TestAccLightsailDomainEntry_apex
=== RUN   TestAccLightsailDomainEntry_disappears
=== PAUSE TestAccLightsailDomainEntry_disappears
=== RUN   TestAccLightsailDomain_basic
=== PAUSE TestAccLightsailDomain_basic
=== RUN   TestAccLightsailDomain_disappears
=== PAUSE TestAccLightsailDomain_disappears
=== CONT  TestAccLightsailDomainEntry_basic
=== CONT  TestAccLightsailDomainEntry_disappears
=== CONT  TestAccLightsailDomainEntry_apex
=== CONT  TestAccLightsailDomain_disappears
=== CONT  TestAccLightsailDomainEntry_underscore
=== CONT  TestAccLightsailDomain_basic
--- PASS: TestAccLightsailDomain_disappears (16.96s)
--- PASS: TestAccLightsailDomain_basic (19.93s)
--- PASS: TestAccLightsailDomainEntry_disappears (33.49s)
--- PASS: TestAccLightsailDomainEntry_apex (39.17s)
--- PASS: TestAccLightsailDomainEntry_basic (39.75s)
--- PASS: TestAccLightsailDomainEntry_underscore (39.90s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  43.054s

LB:
 make testacc TESTARGS='-run=TestAccLightsailLoad' PKG=lightsail     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailLoad -timeout 180m
=== RUN   TestAccLightsailLoadBalancer_serial
=== PAUSE TestAccLightsailLoadBalancer_serial
=== CONT  TestAccLightsailLoadBalancer_serial
=== RUN   TestAccLightsailLoadBalancer_serial/lb
=== RUN   TestAccLightsailLoadBalancer_serial/lb/health_check_path
=== RUN   TestAccLightsailLoadBalancer_serial/lb/tags
=== RUN   TestAccLightsailLoadBalancer_serial/lb/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb/disappears
=== RUN   TestAccLightsailLoadBalancer_serial/lb/name

=== RUN   TestAccLightsailLoadBalancer_serial/lb_attachment
=== RUN   TestAccLightsailLoadBalancer_serial/lb_attachment/basic

=== RUN   TestAccLightsailLoadBalancer_serial/lb_attachment/disappears

=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate/disappears
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate/domain_validation_records
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate/subject_alternative_names
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate_attachment
=== RUN   TestAccLightsailLoadBalancer_serial/lb_certificate_attachment/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy
=== RUN   TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/disappears
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/basic
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/cookie_duration
=== RUN   TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/enabled
--- PASS: TestAccLightsailLoadBalancer_serial (3525.95s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb (813.52s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/health_check_path (151.95s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/tags (147.06s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/basic (133.52s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/disappears (130.30s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb/name (250.68s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_attachment (1052.94s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_attachment/basic (533.68s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_attachment/disappears (519.26s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate (743.68s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/basic (185.97s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/disappears (174.61s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/domain_validation_records (175.75s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate/subject_alternative_names (207.34s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate_attachment (158.55s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_certificate_attachment/basic (158.55s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy (126.69s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_https_redirection_policy/basic (126.69s)
    --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy (630.57s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/disappears (146.66s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/basic (150.48s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/cookie_duration (172.19s)
        --- PASS: TestAccLightsailLoadBalancer_serial/lb_stickiness_policy/enabled (161.24s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  3529.106s

Static:
make testacc TESTARGS='-run=TestAccLightsailStatic' PKG=lightsail     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailStatic -timeout 180m
=== RUN   TestAccLightsailStaticIPAttachment_basic
=== PAUSE TestAccLightsailStaticIPAttachment_basic
=== RUN   TestAccLightsailStaticIPAttachment_disappears
=== PAUSE TestAccLightsailStaticIPAttachment_disappears
=== RUN   TestAccLightsailStaticIP_basic
=== PAUSE TestAccLightsailStaticIP_basic
=== RUN   TestAccLightsailStaticIP_disappears
=== PAUSE TestAccLightsailStaticIP_disappears
=== CONT  TestAccLightsailStaticIPAttachment_basic
=== CONT  TestAccLightsailStaticIP_disappears
=== CONT  TestAccLightsailStaticIPAttachment_disappears
=== CONT  TestAccLightsailStaticIP_basic
--- PASS: TestAccLightsailStaticIP_disappears (15.53s)
--- PASS: TestAccLightsailStaticIP_basic (17.93s)
--- PASS: TestAccLightsailStaticIPAttachment_basic (81.22s)
--- PASS: TestAccLightsailStaticIPAttachment_disappears (112.49s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  115.792s

Instance: 
 make testacc TESTARGS='-run=TestAccLightsailInstance' PKG=lightsail     

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailInstance -timeout 180m
=== RUN   TestAccLightsailInstancePublicPorts_basic
=== PAUSE TestAccLightsailInstancePublicPorts_basic
=== RUN   TestAccLightsailInstancePublicPorts_multiple
=== PAUSE TestAccLightsailInstancePublicPorts_multiple
=== RUN   TestAccLightsailInstancePublicPorts_cidrs
=== PAUSE TestAccLightsailInstancePublicPorts_cidrs
=== RUN   TestAccLightsailInstancePublicPorts_cidrListAliases
=== PAUSE TestAccLightsailInstancePublicPorts_cidrListAliases
=== RUN   TestAccLightsailInstancePublicPorts_disappears
=== PAUSE TestAccLightsailInstancePublicPorts_disappears
=== RUN   TestAccLightsailInstancePublicPorts_disappears_Instance
=== PAUSE TestAccLightsailInstancePublicPorts_disappears_Instance
=== RUN   TestAccLightsailInstance_basic
=== PAUSE TestAccLightsailInstance_basic
=== RUN   TestAccLightsailInstance_name
=== PAUSE TestAccLightsailInstance_name
=== RUN   TestAccLightsailInstance_tags
=== PAUSE TestAccLightsailInstance_tags
=== RUN   TestAccLightsailInstance_IPAddressType
=== PAUSE TestAccLightsailInstance_IPAddressType
=== RUN   TestAccLightsailInstance_addOn
=== PAUSE TestAccLightsailInstance_addOn
=== RUN   TestAccLightsailInstance_availabilityZone
    instance_test.go:280: skipping test; environment variable TF_AWS_LIGHTSAIL_AVAILABILITY_ZONE must be set. Usage: The availability zone that is outside the providers current region.
--- SKIP: TestAccLightsailInstance_availabilityZone (0.00s)
=== RUN   TestAccLightsailInstance_disappears
=== PAUSE TestAccLightsailInstance_disappears
=== CONT  TestAccLightsailInstancePublicPorts_basic
=== CONT  TestAccLightsailInstance_basic
=== CONT  TestAccLightsailInstance_name
=== CONT  TestAccLightsailInstancePublicPorts_multiple
=== CONT  TestAccLightsailInstance_IPAddressType
=== CONT  TestAccLightsailInstance_disappears
=== CONT  TestAccLightsailInstance_addOn
=== CONT  TestAccLightsailInstancePublicPorts_cidrListAliases
=== CONT  TestAccLightsailInstancePublicPorts_disappears_Instance
=== CONT  TestAccLightsailInstancePublicPorts_disappears
=== CONT  TestAccLightsailInstancePublicPorts_cidrs
=== CONT  TestAccLightsailInstance_tags
--- PASS: TestAccLightsailInstancePublicPorts_disappears_Instance (62.96s)
--- PASS: TestAccLightsailInstancePublicPorts_cidrs (63.18s)
--- PASS: TestAccLightsailInstance_disappears (70.49s)
--- PASS: TestAccLightsailInstance_basic (73.26s)
--- PASS: TestAccLightsailInstancePublicPorts_cidrListAliases (76.20s)
--- PASS: TestAccLightsailInstancePublicPorts_disappears (76.27s)
--- PASS: TestAccLightsailInstancePublicPorts_basic (76.92s)
--- PASS: TestAccLightsailInstancePublicPorts_multiple (77.56s)
--- PASS: TestAccLightsailInstance_IPAddressType (85.45s)
--- PASS: TestAccLightsailInstance_tags (88.00s)
--- PASS: TestAccLightsailInstance_name (183.35s)
--- PASS: TestAccLightsailInstance_addOn (273.36s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  276.774s

Database:
make testacc TESTARGS='-run=TestAccLightsailDatabase' PKG=lightsail     

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailDatabase -timeout 180m
=== RUN   TestAccLightsailDatabase_basic
=== PAUSE TestAccLightsailDatabase_basic
=== RUN   TestAccLightsailDatabase_relationalDatabaseName
=== PAUSE TestAccLightsailDatabase_relationalDatabaseName
=== RUN   TestAccLightsailDatabase_masterDatabaseName
=== PAUSE TestAccLightsailDatabase_masterDatabaseName
=== RUN   TestAccLightsailDatabase_masterUsername
=== PAUSE TestAccLightsailDatabase_masterUsername
=== RUN   TestAccLightsailDatabase_masterPassword
=== PAUSE TestAccLightsailDatabase_masterPassword
=== RUN   TestAccLightsailDatabase_preferredBackupWindow
=== PAUSE TestAccLightsailDatabase_preferredBackupWindow
=== RUN   TestAccLightsailDatabase_preferredMaintenanceWindow
=== PAUSE TestAccLightsailDatabase_preferredMaintenanceWindow
=== RUN   TestAccLightsailDatabase_publiclyAccessible
=== PAUSE TestAccLightsailDatabase_publiclyAccessible
=== RUN   TestAccLightsailDatabase_backupRetentionEnabled
=== PAUSE TestAccLightsailDatabase_backupRetentionEnabled
=== RUN   TestAccLightsailDatabase_finalSnapshotName
=== PAUSE TestAccLightsailDatabase_finalSnapshotName
=== RUN   TestAccLightsailDatabase_tags
=== PAUSE TestAccLightsailDatabase_tags
=== RUN   TestAccLightsailDatabase_ha
=== PAUSE TestAccLightsailDatabase_ha
=== RUN   TestAccLightsailDatabase_disappears
=== PAUSE TestAccLightsailDatabase_disappears
=== CONT  TestAccLightsailDatabase_basic
=== CONT  TestAccLightsailDatabase_tags
=== CONT  TestAccLightsailDatabase_masterDatabaseName
=== CONT  TestAccLightsailDatabase_publiclyAccessible
=== CONT  TestAccLightsailDatabase_masterPassword
=== CONT  TestAccLightsailDatabase_finalSnapshotName
=== CONT  TestAccLightsailDatabase_preferredMaintenanceWindow
=== CONT  TestAccLightsailDatabase_preferredBackupWindow
=== CONT  TestAccLightsailDatabase_backupRetentionEnabled
=== CONT  TestAccLightsailDatabase_masterUsername
=== CONT  TestAccLightsailDatabase_disappears
=== CONT  TestAccLightsailDatabase_relationalDatabaseName
=== CONT  TestAccLightsailDatabase_ha
=== NAME  TestAccLightsailDatabase_preferredBackupWindow
--- FAIL: TestAccLightsailDatabase_preferredBackupWindow (4.81s)
--- FAIL: TestAccLightsailDatabase_preferredMaintenanceWindow (5.04s)
--- PASS: TestAccLightsailDatabase_masterPassword (13.42s)
=== NAME  TestAccLightsailDatabase_disappears
--- FAIL: TestAccLightsailDatabase_disappears (681.78s)
--- PASS: TestAccLightsailDatabase_backupRetentionEnabled (972.17s)
--- PASS: TestAccLightsailDatabase_tags (1024.80s)
--- PASS: TestAccLightsailDatabase_relationalDatabaseName (1043.84s)
--- PASS: TestAccLightsailDatabase_publiclyAccessible (1076.61s)
--- PASS: TestAccLightsailDatabase_basic (1095.12s)
--- PASS: TestAccLightsailDatabase_finalSnapshotName (1208.95s)
--- PASS: TestAccLightsailDatabase_ha (1856.93s)
--- PASS: TestAccLightsailDatabase_masterDatabaseName (2047.18s)
--- PASS: TestAccLightsailDatabase_masterUsername (2115.63s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  2118.931s
FAIL
make: *** [testacc] Error 1

make testacc TESTARGS='-run=TestAccLightsailDatabase_disappears' PKG=lightsail     
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailDatabase_disappears -timeout 180m
=== RUN   TestAccLightsailDatabase_disappears
=== PAUSE TestAccLightsailDatabase_disappears
=== CONT  TestAccLightsailDatabase_disappears
--- PASS: TestAccLightsailDatabase_disappears (605.04s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  608.299s

make testacc TESTARGS='-run=TestAccLightsailContainerService_' PKG=lightsail 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20  -run=TestAccLightsailContainerService_ -timeout 180m
=== RUN   TestAccLightsailContainerService_basic
=== PAUSE TestAccLightsailContainerService_basic
=== RUN   TestAccLightsailContainerService_disappears
=== PAUSE TestAccLightsailContainerService_disappears
=== RUN   TestAccLightsailContainerService_name
=== PAUSE TestAccLightsailContainerService_name
=== RUN   TestAccLightsailContainerService_isDisabled
=== PAUSE TestAccLightsailContainerService_isDisabled
=== RUN   TestAccLightsailContainerService_power
=== PAUSE TestAccLightsailContainerService_power
=== RUN   TestAccLightsailContainerService_publicDomainNames
=== PAUSE TestAccLightsailContainerService_publicDomainNames
=== RUN   TestAccLightsailContainerService_privateRegistryAccess
=== PAUSE TestAccLightsailContainerService_privateRegistryAccess
=== RUN   TestAccLightsailContainerService_scale
=== PAUSE TestAccLightsailContainerService_scale
=== RUN   TestAccLightsailContainerService_tags
=== PAUSE TestAccLightsailContainerService_tags
=== CONT  TestAccLightsailContainerService_basic
=== CONT  TestAccLightsailContainerService_publicDomainNames
=== CONT  TestAccLightsailContainerService_scale
=== CONT  TestAccLightsailContainerService_name
=== CONT  TestAccLightsailContainerService_tags
=== CONT  TestAccLightsailContainerService_disappears
=== CONT  TestAccLightsailContainerService_power
=== CONT  TestAccLightsailContainerService_isDisabled
=== CONT  TestAccLightsailContainerService_privateRegistryAccess
--- PASS: TestAccLightsailContainerService_publicDomainNames (45.34s)
--- PASS: TestAccLightsailContainerService_disappears (143.33s)
--- PASS: TestAccLightsailContainerService_privateRegistryAccess (156.21s)
--- PASS: TestAccLightsailContainerService_power (250.49s)
--- PASS: TestAccLightsailContainerService_basic (259.39s)
--- PASS: TestAccLightsailContainerService_isDisabled (281.63s)
--- PASS: TestAccLightsailContainerService_name (296.46s)
--- PASS: TestAccLightsailContainerService_scale (304.67s)
--- PASS: TestAccLightsailContainerService_tags (317.68s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  318.111s
...

@brittandeyoung
Amend go.mod, Add lightsail aws go sdk v2
33b3298
@brittandeyoung
names: Amend names_data.csv, update lightsail to go sdk v2
d753c05
@brittandeyoung
conns: Amend awsclient_gen, run generate to update lightsail to aws g…
d291e4c 
…o sdk v2
@brittandeyoung
Merge remote-tracking branch 'upstream/main' into td-lightsail-aws-go…
ce922d3 
…-sdk-v2
@brittandeyoung
go mod tidy
f117534
@brittandeyoung
lightsail: Amend bucket, migrate resource to aws-go-sdk-v2
486e525
@brittandeyoung
lightsail: Amend bucket_access_key, migrate resource to aws-go-sdk-v2
5fd7734
@brittandeyoung
lightsail: Amend bucke_access_key_test, migrate resource to aws-go-sd…
bf926d1 
…k-v2
@brittandeyoung
lightsail: Amend bucket_resource_access, migrate resource to aws-go-s…
2c0fd8b 
…dk-v2
@brittandeyoung
lightsail: Amend bucket_resource_access_test, migrate resource to aws…
907b0a0 
…-go-sdk-v2
@brittandeyoung
lightsail: Amend bucket_test, migrate resource to aws-go-sdk-v2
80da183
@brittandeyoung
lightsail: Amend certificate, migrate resource to aws-go-sdk-v2
23698ae
@brittandeyoung
lightsail: Amend certificate_test, migrate resource to aws-go-sdk-v2
10a9a52
@brittandeyoung
lightsail: Amend container_service_deployment_version_test, migrate r…
b1e9ff5 
…esource to aws-go-sdk-v2
@brittandeyoung
lightsail: Amend container_service_test, migrate resource to aws-go-s…
7b9d4bc 
…dk-v2
@brittandeyoung
lightsail: Amend database, migrate resource to aws-go-sdk-v2
13b9843
@brittandeyoung
lightsail: Amend database_test, migrate resource to aws-go-sdk-v2
b4907db
@brittandeyoung
lightsail: Amend disk, migrate resource to aws-go-sdk-v2
6c761b8
@brittandeyoung
lightsail: Amend disk_attachment, migrate resource to aws-go-sdk-v2
d064fb2
@brittandeyoung
lightsail: Amend disk_attachment_test, migrate resource to aws-go-sdk-v2
d743d56
@brittandeyoung
lightsail: Amend disk_test, migrate resource to aws-go-sdk-v2
c367b11
@brittandeyoung
lightsail: Amend distribution, migrate resource to aws-go-sdk-v2
edf441f
@brittandeyoung
lightsail: Amend distribution_test, migrate resource to aws-go-sdk-v2
fb44931
@brittandeyoung
lightsail: Amend domain, migrate resource to aws-go-sdk-v2
1e7ac41
@brittandeyoung
lightsail: Amend domain_entry, migrate resource to aws-go-sdk-v2
0091cca
@brittandeyoung
lightsail: Amend domain_entry_test, migrate resource to aws-go-sdk-v2
27dd52c
@brittandeyoung
lightsail: Amend domain_test, migrate resource to aws-go-sdk-v2
7389720
@brittandeyoung
lightsail: Amend flex, migrate resource to aws-go-sdk-v2
2cab01a
@brittandeyoung
lightsail: Amend instance, migrate resource to aws-go-sdk-v2
c8f62a5
@brittandeyoung
lightsail: Amend instance_public_ports, migrate resource to aws-go-sd…
bd2a46b 
…k-v2
@justinretzolk justinretzolk added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 8, 2023
brittandeyoung and others added 19 commits June 9, 2023 13:27
@brittandeyoung
conns: move lightsail to manual client
7aba504
@brittandeyoung
lightsail: Amend container_service_deployment_version, fix container …
65a3e00 
…pointer
@brittandeyoung
lightsail: Amend container_service_deployment_version_test, Remove se…
150105b 
…rialized tests
@brittandeyoung
lightsail: Amend container_service_test, remove serialized runner
c8216e6
@brittandeyoung
lightsail: Amend distribution, move to enum.Slice
51f7d47
@brittandeyoung
lightsail: Amend sweep, resolve build issues
8b9271c
@brittandeyoung
lightsail: Amend wait, move to enum.Slice
5b75763
@brittandeyoung
conns: Amend config, add custom lightsailClient config with retries
c2bf7ea
@brittandeyoung
Merge remote-tracking branch 'upstream/main' into td-lightsail-aws-go…
4c1e1f5 
…-sdk-v2
@brittandeyoung
lightsail: Amend container_service_test, fmt
0060845
@brittandeyoung
lightsail: Amend instance_test, fmt
cd59f70
@brittandeyoung
conns: Amend config, resolve lightsail retry
ae34eb0
@brittandeyoung
conns: Amend config, move number to const
eaebccd
@brittandeyoung
lightsail: Amend bucket_access_key, remove type conversion in loop
ef7cc5d
@brittandeyoung
lightsail: Amend bucket_resource_access, remove type conversion in loop
d990d44
@brittandeyoung
lightsail: Amend container_service_deployment_version, remove type co…
a182d82 
…nversion in loop
@brittandeyoung
lightsail: Amend domain_entry, remove type conversion
7967cff
@brittandeyoung
lightsail: Amend lb_certificate, remove type conversion in loop
70a74b5
@ewbankkit
Merge branch 'main' into HEAD
5f27617 
# Conflicts:
#	internal/conns/awsclient_gen.go
#	internal/service/lightsail/bucket.go
#	internal/service/lightsail/bucket_access_key.go
#	internal/service/lightsail/bucket_access_key_test.go
#	internal/service/lightsail/bucket_resource_access.go
#	internal/service/lightsail/bucket_resource_access_test.go
#	internal/service/lightsail/bucket_test.go
#	internal/service/lightsail/certificate.go
#	internal/service/lightsail/certificate_test.go
#	internal/service/lightsail/container_service.go
#	internal/service/lightsail/container_service_deployment_version.go
#	internal/service/lightsail/container_service_deployment_version_test.go
#	internal/service/lightsail/container_service_test.go
#	internal/service/lightsail/database.go
#	internal/service/lightsail/database_test.go
#	internal/service/lightsail/disk.go
#	internal/service/lightsail/disk_attachment.go
#	internal/service/lightsail/disk_attachment_test.go
#	internal/service/lightsail/disk_test.go
#	internal/service/lightsail/distribution.go
#	internal/service/lightsail/distribution_test.go
#	internal/service/lightsail/domain.go
#	internal/service/lightsail/domain_entry.go
#	internal/service/lightsail/domain_entry_test.go
#	internal/service/lightsail/domain_test.go
#	internal/service/lightsail/instance.go
#	internal/service/lightsail/instance_public_ports.go
#	internal/service/lightsail/instance_public_ports_test.go
#	internal/service/lightsail/instance_test.go
#	internal/service/lightsail/key_pair.go
#	internal/service/lightsail/key_pair_test.go
#	internal/service/lightsail/lb.go
#	internal/service/lightsail/lb_attachment.go
#	internal/service/lightsail/lb_attachment_test.go
#	internal/service/lightsail/lb_certificate.go
#	internal/service/lightsail/lb_certificate_attachment.go
#	internal/service/lightsail/lb_certificate_test.go
#	internal/service/lightsail/lb_https_redirection_policy.go
#	internal/service/lightsail/lb_stickiness_policy.go
#	internal/service/lightsail/lb_stickiness_policy_test.go
#	internal/service/lightsail/lb_test.go
#	internal/service/lightsail/static_ip.go
#	internal/service/lightsail/static_ip_attachment.go
#	internal/service/lightsail/static_ip_attachment_test.go
#	internal/service/lightsail/static_ip_test.go
#	internal/service/lightsail/sweep.go
#	internal/service/lightsail/tags_gen.go
ewbankkit
ewbankkit approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLightsail.*_basic$$' PKG=lightsail ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 2  -run=TestAccLightsail.*_basic$ -timeout 180m
=== RUN   TestAccLightsailBucketAccessKey_basic
=== PAUSE TestAccLightsailBucketAccessKey_basic
=== RUN   TestAccLightsailBucketResourceAccess_basic
=== PAUSE TestAccLightsailBucketResourceAccess_basic
=== RUN   TestAccLightsailBucket_basic
=== PAUSE TestAccLightsailBucket_basic
=== RUN   TestAccLightsailCertificate_basic
=== PAUSE TestAccLightsailCertificate_basic
=== RUN   TestAccLightsailContainerServiceDeploymentVersion_container_basic
=== PAUSE TestAccLightsailContainerServiceDeploymentVersion_container_basic
=== RUN   TestAccLightsailContainerService_basic
=== PAUSE TestAccLightsailContainerService_basic
=== RUN   TestAccLightsailDatabase_basic
=== PAUSE TestAccLightsailDatabase_basic
=== RUN   TestAccLightsailDiskAttachment_basic
=== PAUSE TestAccLightsailDiskAttachment_basic
=== RUN   TestAccLightsailDisk_basic
=== PAUSE TestAccLightsailDisk_basic
=== RUN   TestAccLightsailDomainEntry_basic
=== PAUSE TestAccLightsailDomainEntry_basic
=== RUN   TestAccLightsailDomain_basic
=== PAUSE TestAccLightsailDomain_basic
=== RUN   TestAccLightsailInstancePublicPorts_basic
=== PAUSE TestAccLightsailInstancePublicPorts_basic
=== RUN   TestAccLightsailInstance_basic
=== PAUSE TestAccLightsailInstance_basic
=== RUN   TestAccLightsailKeyPair_basic
=== PAUSE TestAccLightsailKeyPair_basic
=== RUN   TestAccLightsailStaticIPAttachment_basic
=== PAUSE TestAccLightsailStaticIPAttachment_basic
=== RUN   TestAccLightsailStaticIP_basic
=== PAUSE TestAccLightsailStaticIP_basic
=== CONT  TestAccLightsailBucketAccessKey_basic
=== CONT  TestAccLightsailDisk_basic
--- PASS: TestAccLightsailBucketAccessKey_basic (59.52s)
=== CONT  TestAccLightsailInstance_basic
--- PASS: TestAccLightsailDisk_basic (68.81s)
=== CONT  TestAccLightsailStaticIP_basic
--- PASS: TestAccLightsailStaticIP_basic (23.10s)
=== CONT  TestAccLightsailStaticIPAttachment_basic
--- PASS: TestAccLightsailInstance_basic (69.52s)
=== CONT  TestAccLightsailKeyPair_basic
--- PASS: TestAccLightsailKeyPair_basic (33.46s)
=== CONT  TestAccLightsailContainerServiceDeploymentVersion_container_basic
--- PASS: TestAccLightsailStaticIPAttachment_basic (97.09s)
=== CONT  TestAccLightsailDiskAttachment_basic
--- PASS: TestAccLightsailDiskAttachment_basic (218.95s)
=== CONT  TestAccLightsailDatabase_basic
--- PASS: TestAccLightsailContainerServiceDeploymentVersion_container_basic (505.36s)
=== CONT  TestAccLightsailContainerService_basic
--- PASS: TestAccLightsailContainerService_basic (120.14s)
=== CONT  TestAccLightsailBucket_basic
--- PASS: TestAccLightsailBucket_basic (39.70s)
=== CONT  TestAccLightsailCertificate_basic
--- PASS: TestAccLightsailCertificate_basic (58.28s)
=== CONT  TestAccLightsailBucketResourceAccess_basic
--- PASS: TestAccLightsailBucketResourceAccess_basic (125.06s)
=== CONT  TestAccLightsailDomain_basic
    acctest.go:848: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccLightsailDomain_basic (0.00s)
=== CONT  TestAccLightsailInstancePublicPorts_basic
--- PASS: TestAccLightsailInstancePublicPorts_basic (77.94s)
=== CONT  TestAccLightsailDomainEntry_basic
    acctest.go:848: skipping tests; AWS_DEFAULT_REGION (us-west-2) not supported. Supported: [us-east-1]
--- SKIP: TestAccLightsailDomainEntry_basic (0.00s)
--- PASS: TestAccLightsailDatabase_basic (955.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	1370.575s

@ewbankkit ewbankkit added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Jun 12, 2023
@ewbankkit
Copy link
Contributor

@brittandeyoung Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 4dccf99 into hashicorp:main Jun 12, 2023
@github-actions github-actions bot added this to the v5.3.0 milestone Jun 12, 2023
@github-actions
Copy link

This functionality has been released in v5.3.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2023
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. enhancement Requests to existing resources that expand the functionality or scope. generators Relates to code generators. service/lightsail Issues and PRs that pertain to the lightsail service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@brittandeyoung @ewbankkit @justinretzolk