Bug: Missing shared directory resources on read

[drewtul]

Description

Change this method to page results like the others, it's possible the API returns a non-null NextToken while the SharedDirectories array is empty. Paging is consistent with the AWS CLI and allows us to find the required shared directory.

Not paging means for directories with large numbers of shares the provider believes the resource has been deleted outside of terraform and attempts to recreate the resources, which fails.

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @drewtul 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[jar-b]

LGTM 🎉

$ make testacc PKG=ds TESTS=TestAccDSSharedDirectory_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ds/... -v -count 1 -parallel 20 -run='TestAccDSSharedDirectory_'  -timeout 180m
=== RUN   TestAccDSSharedDirectory_basic
=== PAUSE TestAccDSSharedDirectory_basic
=== CONT  TestAccDSSharedDirectory_basic
--- PASS: TestAccDSSharedDirectory_basic (1583.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ds 1587.042s

[jar-b]

Thanks for your contribution, @drewtul! 👏

[github-actions]

This functionality has been released in v4.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.