Merge branch 'main' into td-migrate-glacier-to-aws-sdk-v2

# Conflicts: # internal/service/glacier/vault.go # internal/service/glacier/vault_lock.go
hashicorp · Jun 7, 2023 · a0a6ee1 · a0a6ee1
2 parents aa02cb6 + 661b273
commit a0a6ee1
Show file tree

Hide file tree

Showing 287 changed files with 11,735 additions and 430 deletions.
diff --git a/.changelog/31800.txt b/.changelog/31800.txt
diff --git a/.changelog/31801.txt b/.changelog/31801.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+resource/aws_vpc_endpoint: Fix tagging error preventing use in ISO partitions
+```
diff --git a/.changelog/31826.txt b/.changelog/31826.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+provider/default_tags: Fix perpetual diff when identical tags are moved from `default_tags` to resource `tags`, and vice versa
+```
diff --git a/.ci/providerlint/go.mod b/.ci/providerlint/go.mod
@@ -3,7 +3,7 @@ module github.com/hashicorp/terraform-provider-aws/ci/providerlint
 go 1.19
 
 require (
- github.com/aws/aws-sdk-go v1.44.276
+ github.com/aws/aws-sdk-go v1.44.277
  github.com/bflad/tfproviderlint v0.29.0
  github.com/hashicorp/terraform-plugin-sdk/v2 v2.26.1
  golang.org/x/tools v0.8.0

diff --git a/.ci/providerlint/go.sum b/.ci/providerlint/go.sum
@@ -20,8 +20,8 @@ github.com/apparentlymart/go-textseg/v13 v13.0.0 h1:Y+KvPE1NYz0xl601PVImeQfFyEy6
 github.com/apparentlymart/go-textseg/v13 v13.0.0/go.mod h1:ZK2fH7c4NqDTLtiYLvIkEghdlcqw7yxLeM89kiTRPUo=
 github.com/armon/go-radix v0.0.0-20180808171621-7fddfc383310/go.mod h1:ufUuZ+zHj4x4TnLV4JWEpy2hxWSpsRywHrMgIH9cCH8=
 github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5/go.mod h1:wHh0iHkYZB8zMSxRWpUBQtwG5a7fFgvEO+odwuTv2gs=
-github.com/aws/aws-sdk-go v1.44.276 h1:ywPlx9C5Yc482dUgAZ9bHpQ6onVvJvYE9FJWsNDCEy0=
-github.com/aws/aws-sdk-go v1.44.276/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI=
+github.com/aws/aws-sdk-go v1.44.277 h1:YHmyzBPARTJ7LLYV1fxbfEbQOaUh3kh52hb7nBvX3BQ=
+github.com/aws/aws-sdk-go v1.44.277/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI=
 github.com/bflad/gopaniccheck v0.1.0 h1:tJftp+bv42ouERmUMWLoUn/5bi/iQZjHPznM00cP/bU=
 github.com/bflad/gopaniccheck v0.1.0/go.mod h1:ZCj2vSr7EqVeDaqVsWN4n2MwdROx1YL+LFo47TSWtsA=
 github.com/bflad/tfproviderlint v0.29.0 h1:zxKYAAM6IZ4ace1a3LX+uzMRIMP8L+iOtEc+FP2Yoow=

diff --git a/.ci/providerlint/vendor/github.com/aws/aws-sdk-go/aws/endpoints/defaults.go b/.ci/providerlint/vendor/github.com/aws/aws-sdk-go/aws/endpoints/defaults.go
diff --git a/.ci/providerlint/vendor/modules.txt b/.ci/providerlint/vendor/modules.txt
@@ -4,7 +4,7 @@ github.com/agext/levenshtein
 # github.com/apparentlymart/go-textseg/v13 v13.0.0
 ## explicit; go 1.16
 github.com/apparentlymart/go-textseg/v13/textseg
-# github.com/aws/aws-sdk-go v1.44.276
+# github.com/aws/aws-sdk-go v1.44.277
 ## explicit; go 1.11
 github.com/aws/aws-sdk-go/aws/awserr
 github.com/aws/aws-sdk-go/aws/endpoints

diff --git a/.ci/semgrep/errors/msgfmt.yml b/.ci/semgrep/errors/msgfmt.yml
@@ -40,3 +40,20 @@ rules:
  patterns:
  - pattern-regex: 'AppendErrorf\(diags, "\s*[Ee]rror '
  severity: ERROR
+
+ # To fix:
+ # find internal -name '*.go' ! -name 'sweep.go' ! -name '*_test.go' -print | xargs ruby -p -i -e 'gsub(/fmt.Errorf\((")error (.*)\)/, "fmt.Errorf(\\1\\2)")'
+ # find internal -name '*.go' ! -name 'sweep.go' ! -name '*_test.go' -print | xargs ruby -p -i -e 'gsub(/fmt.Errorf\((")Error (.*)\)/, "fmt.Errorf(\\1\\2)")'
+ - id: no-fmt.Errorf-leading-error
+ languages: [go]
+ message: Remove leading 'error ' from fmt.Errorf("error ...")
+ paths:
+ include:
+ - internal/
+ exclude:
+ - "internal/service/**/*_test.go"
+ - "internal/service/**/sweep.go"
+ - "internal/acctest/acctest.go"
+ patterns:
+ - pattern-regex: 'fmt.Errorf\("\s*[Ee]rror '
+ severity: ERROR
diff --git a/.github/workflows/cdktf-documentation.yml b/.github/workflows/cdktf-documentation.yml
@@ -0,0 +1,53 @@
+name: CDKTF Documentation
+on:
+ schedule:
+ - cron: "0 0 * * WED"
+ workflow_dispatch: {}
+
+permissions:
+ contents: write
+ pull-requests: write
+
+jobs:
+ cdktfDocs:
+ runs-on: ubuntu-latest
+ container:
+ image: docker.mirror.hashicorp.services/hashicorp/jsii-terraform
+ env:
+ CHECKPOINT_DISABLE: "1"
+ timeout-minutes: 120
+ steps:
+ - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab # v3.5.2
+ - run: git config --global user.email "[email protected]"
+ - run: git config --global user.name "team-tf-cdk"
+ - name: Get yarn cache directory path
+ id: global-cache-dir-path
+ run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
+ - uses: actions/cache@88522ab9f39a2ea568f7027eddc7d8d8bc9d59c8 # v3.3.1
+ id: global-cache
+ with:
+ path: ${{ steps.global-cache-dir-path.outputs.dir }}
+ key: ${{ runner.os }}-integration-yarn-${{ hashFiles('**/yarn.lock') }}
+ - name: Setup Node.js
+ uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
+ with:
+ node-version: "18.x"
+ - name: Install cdktf-registry-docs
+ run: npm install -g [email protected]
+ - name: Run conversion
+ run: |
+ cdktf-registry-docs convert \
+ --files='*/ec2_*.html.markdown' \
+ --languages='typescript,python' \
+ --parallel-conversions-per-document=1 \
+ --provider-from-registry="hashicorp/aws" \
+ .
+ env:
+ TF_PLUGIN_CACHE_DIR: ${{ steps.global-cache-dir-path.outputs.dir }}/terraform-plugins
+
+ - name: Create Pull Request
+ uses: peter-evans/create-pull-request@284f54f989303d2699d373481a0cfa13ad5a6666 # v5.0.1
+ with:
+ commit-message: "docs: update cdktf documentation"
+ title: "docs: update cdktf documentation"
+ body: "This PR updates the cdktf related documentation based on the current HCL-based documentation. It is automatically created by the cdktf-documentation GitHub action."
diff --git a/.github/workflows/team_slack_bot.yml b/.github/workflows/team_slack_bot.yml
@@ -11,7 +11,7 @@ jobs:
  if: github.repository_owner == 'hashicorp'
  steps:
  - name: open-pr-stats
- uses: breathingdust/github-team-slackbot@f54b7983243d7f5a015b659f71d3c3dbe7b04001
+ uses: breathingdust/github-team-slackbot@8f1053f9b472b94e6564ebc499a92136c48ace1f
  with:
  github_token: ${{ secrets.ORGSCOPED_GITHUB_TOKEN}}
  org: hashicorp

diff --git a/.github/workflows/terraform_provider.yml b/.github/workflows/terraform_provider.yml
@@ -4,7 +4,7 @@ on:
  push:
  branches:
  - main
- - 'release/**'
+ - "release/**"
  pull_request:
  paths:
  - .github/workflows/terraform_provider.yml
@@ -265,13 +265,14 @@ jobs:
  -ignore-file-missing-resources aws_alb,aws_alb_listener,aws_alb_listener_certificate,aws_alb_listener_rule,aws_alb_target_group,aws_alb_target_group_attachment \
  -provider-source registry.terraform.io/hashicorp/aws \
  -providers-schema-json terraform-providers-schema/schema.json \
- -require-resource-subcategory
+ -require-resource-subcategory \
+ -ignore-cdktf-missing-files
 
  markdown-lint:
  runs-on: ubuntu-latest
  steps:
  - uses: actions/checkout@8e5e7e5ab8b370d6c329ec480221332ada57f0ab
  - uses: avto-dev/markdown-lint@04d43ee9191307b50935a753da3b775ab695eceb
  with:
- args: '.'
- ignore: './docs ./website/docs ./CHANGELOG.md ./internal/service/cloudformation/testdata/examplecompany-exampleservice-exampleresource/docs'
+ args: "."
+ ignore: "./docs ./website/docs ./CHANGELOG.md ./internal/service/cloudformation/testdata/examplecompany-exampleservice-exampleresource/docs"
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,12 +22,13 @@ ENHANCEMENTS:
 BUG FIXES:
 
 * data-source/aws_redshift_cluster: Fix crash reading clusters in `modifying` state ([#31772](https://github.com/hashicorp/terraform-provider-aws/issues/31772))
+* provider/default_tags: Fix perpetual diff when identical tags are moved from `default_tags` to resource `tags`, and vice versa ([#31826](https://github.com/hashicorp/terraform-provider-aws/issues/31826))
 * resource/aws_dx_connection: Convert `vlan_id` from [`TypeString`](https://developer.hashicorp.com/terraform/plugin/sdkv2/schemas/schema-types#typestring) to [`TypeInt`](https://developer.hashicorp.com/terraform/plugin/sdkv2/schemas/schema-types#typeint) in [Terraform state](https://developer.hashicorp.com/terraform/language/state) for existing resources. This fixes a regression introduced in [v5.1.0](https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#510-june--1-2023) causing `a number is required` errors ([#31735](https://github.com/hashicorp/terraform-provider-aws/issues/31735))
 * resource/aws_globalaccelerator_endpoint_group: Fix bug updating `endpoint_configuration.weight` to `0` ([#31767](https://github.com/hashicorp/terraform-provider-aws/issues/31767))
 * resource/aws_redshiftserverless_namespace: Fix perpetual `iam_roles` diffs when the namespace contains a workgroup ([#31749](https://github.com/hashicorp/terraform-provider-aws/issues/31749))
 * resource/aws_redshiftserverless_workgroup: Change `config_parameter` from `TypeList` to `TypeSet` as order is not significant ([#31747](https://github.com/hashicorp/terraform-provider-aws/issues/31747))
 * resource/aws_redshiftserverless_workgroup: Fix `ValidationException: Can't update multiple configurations at the same time` errors ([#31747](https://github.com/hashicorp/terraform-provider-aws/issues/31747))
-* resource/aws_spot_instance_request: Fix IAM eventual consistency errors on resource Create ([#31800](https://github.com/hashicorp/terraform-provider-aws/issues/31800))
+* resource/aws_vpc_endpoint: Fix tagging error preventing use in ISO partitions ([#31801](https://github.com/hashicorp/terraform-provider-aws/issues/31801))
 
 ## 5.1.0 (June 1, 2023)
 

diff --git a/go.mod b/go.mod
@@ -4,7 +4,7 @@ go 1.19
 
 require (
  github.com/ProtonMail/go-crypto v0.0.0-20230201104953-d1d05f4e2bfb
- github.com/aws/aws-sdk-go v1.44.276
+ github.com/aws/aws-sdk-go v1.44.277
  github.com/aws/aws-sdk-go-v2 v1.18.0
  github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.13.3
  github.com/aws/aws-sdk-go-v2/service/accessanalyzer v1.19.12
@@ -24,9 +24,9 @@ require (
  github.com/aws/aws-sdk-go-v2/service/glacier v1.14.11
  github.com/aws/aws-sdk-go-v2/service/healthlake v1.16.0
  github.com/aws/aws-sdk-go-v2/service/identitystore v1.16.11
- github.com/aws/aws-sdk-go-v2/service/inspector2 v1.13.0
+ github.com/aws/aws-sdk-go-v2/service/inspector2 v1.14.0
  github.com/aws/aws-sdk-go-v2/service/ivschat v1.4.5
- github.com/aws/aws-sdk-go-v2/service/kendra v1.40.1
+ github.com/aws/aws-sdk-go-v2/service/kendra v1.40.2
  github.com/aws/aws-sdk-go-v2/service/lambda v1.35.0
  github.com/aws/aws-sdk-go-v2/service/medialive v1.31.4
  github.com/aws/aws-sdk-go-v2/service/oam v1.1.11

diff --git a/go.sum b/go.sum
@@ -21,8 +21,8 @@ github.com/apparentlymart/go-textseg/v13 v13.0.0/go.mod h1:ZK2fH7c4NqDTLtiYLvIkE
 github.com/armon/go-radix v0.0.0-20180808171621-7fddfc383310 h1:BUAU3CGlLvorLI26FmByPp2eC2qla6E1Tw+scpcg/to=
 github.com/armon/go-radix v0.0.0-20180808171621-7fddfc383310/go.mod h1:ufUuZ+zHj4x4TnLV4JWEpy2hxWSpsRywHrMgIH9cCH8=
 github.com/armon/go-socks5 v0.0.0-20160902184237-e75332964ef5/go.mod h1:wHh0iHkYZB8zMSxRWpUBQtwG5a7fFgvEO+odwuTv2gs=
-github.com/aws/aws-sdk-go v1.44.276 h1:ywPlx9C5Yc482dUgAZ9bHpQ6onVvJvYE9FJWsNDCEy0=
-github.com/aws/aws-sdk-go v1.44.276/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI=
+github.com/aws/aws-sdk-go v1.44.277 h1:YHmyzBPARTJ7LLYV1fxbfEbQOaUh3kh52hb7nBvX3BQ=
+github.com/aws/aws-sdk-go v1.44.277/go.mod h1:aVsgQcEevwlmQ7qHE9I3h+dtQgpqhFB+i8Phjh7fkwI=
 github.com/aws/aws-sdk-go-v2 v1.18.0 h1:882kkTpSFhdgYRKVZ/VCgf7sd0ru57p2JCxz4/oN5RY=
 github.com/aws/aws-sdk-go-v2 v1.18.0/go.mod h1:uzbQtefpm44goOPmdKyAlXSNcwlRgF3ePWVW6EtJvvw=
 github.com/aws/aws-sdk-go-v2/aws/protocol/eventstream v1.4.10 h1:dK82zF6kkPeCo8J1e+tGx4JdvDIQzj7ygIoLg8WMuGs=
@@ -75,16 +75,16 @@ github.com/aws/aws-sdk-go-v2/service/iam v1.19.12 h1:JH1H7POlsZt41X9JYIBLZoXW0Qv
 github.com/aws/aws-sdk-go-v2/service/iam v1.19.12/go.mod h1:kAnokExGCYs7zfvZEZdFHvQ/x4ZKIci0Raps6mZI1Ag=
 github.com/aws/aws-sdk-go-v2/service/identitystore v1.16.11 h1:lXvr+mWzICOdOWQAKGPpAgSuA3lw3XEnzuCUMBVFjgs=
 github.com/aws/aws-sdk-go-v2/service/identitystore v1.16.11/go.mod h1:q1wr4mV/OaSB53lfrCL4al7J4ApwOZcy2F8nQ2iTTlw=
-github.com/aws/aws-sdk-go-v2/service/inspector2 v1.13.0 h1:YtnOEbbYqFi6UTCZ1s1YjPDj8q0vOr8qv4UaUemAvc8=
-github.com/aws/aws-sdk-go-v2/service/inspector2 v1.13.0/go.mod h1:DVqRsK8FPNPZmd6XIITp+vakn0DwcfqO/Luo9fdMUZk=
+github.com/aws/aws-sdk-go-v2/service/inspector2 v1.14.0 h1:NKiE3bgx2O74zQdH6Fs9SRt8QImO3kEPeOVMr1DBzn4=
+github.com/aws/aws-sdk-go-v2/service/inspector2 v1.14.0/go.mod h1:DVqRsK8FPNPZmd6XIITp+vakn0DwcfqO/Luo9fdMUZk=
 github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.9.27 h1:0iKliEXAcCa2qVtRs7Ot5hItA2MsufrphbRFlz1Owxo=
 github.com/aws/aws-sdk-go-v2/service/internal/presigned-url v1.9.27/go.mod h1:EOwBD4J4S5qYszS5/3DpkejfuK+Z5/1uzICfPaZLtqw=
 github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.14.2 h1:NbWkRxEEIRSCqxhsHQuMiTH7yo+JZW1gp8v3elSVMTQ=
 github.com/aws/aws-sdk-go-v2/service/internal/s3shared v1.14.2/go.mod h1:4tfW5l4IAB32VWCDEBxCRtR9T4BWy4I4kr1spr8NgZM=
 github.com/aws/aws-sdk-go-v2/service/ivschat v1.4.5 h1:oaAviqCkBc/azk44qUP+w0ZkiNsfFHq+7sdH8N7bKUY=
 github.com/aws/aws-sdk-go-v2/service/ivschat v1.4.5/go.mod h1:hUIzI/1VZP15FYdPE7tBFI/gk9iD1LlEOFMSJTrJZN8=
-github.com/aws/aws-sdk-go-v2/service/kendra v1.40.1 h1:808yGPE8AM5hoNq/eSFTKGRbc6C72VjIYNNFkUwwMas=
-github.com/aws/aws-sdk-go-v2/service/kendra v1.40.1/go.mod h1:00b/aokrZ0r4fUsMP9RSOL9bvxTCCRCOeUy5o0lyqrA=
+github.com/aws/aws-sdk-go-v2/service/kendra v1.40.2 h1:4oiWp0Y9BnBh0x7V4/h3u/qnagKgl5eofYi3bANQWbk=
+github.com/aws/aws-sdk-go-v2/service/kendra v1.40.2/go.mod h1:00b/aokrZ0r4fUsMP9RSOL9bvxTCCRCOeUy5o0lyqrA=
 github.com/aws/aws-sdk-go-v2/service/lambda v1.35.0 h1:iNLsDIOju/bbqw0mNaEXh+9Ms6Mm0RjcHPP9z4k9lUY=
 github.com/aws/aws-sdk-go-v2/service/lambda v1.35.0/go.mod h1:i23nHcGEyswthctBfhEO1agGpM5Uyh83aSmSB6DmdCk=
 github.com/aws/aws-sdk-go-v2/service/medialive v1.31.4 h1:EMIWrz5dNgkqAKUPe6xTLvzwLt2RIRN1P5D8Nrl4XkQ=

diff --git a/internal/conns/awsclient.go b/internal/conns/awsclient.go
@@ -1,9 +1,11 @@
 package conns
 
 import (
+ "context"
  "fmt"
  "net/http"
 
+ "github.com/aws/aws-sdk-go/aws"
  "github.com/aws/aws-sdk-go/aws/endpoints"
  "github.com/aws/aws-sdk-go/service/apigatewayv2"
  "github.com/aws/aws-sdk-go/service/s3"
@@ -23,8 +25,11 @@ func (client *AWSClient) RegionalHostname(prefix string) string {
  return fmt.Sprintf("%s.%s.%s", prefix, client.Region, client.DNSSuffix)
 }
 
-func (client *AWSClient) S3ConnURICleaningDisabled() *s3.S3 {
- return client.s3ConnURICleaningDisabled
+func (client *AWSClient) S3ConnURICleaningDisabled(context.Context) *s3.S3 {
+ config := client.S3Conn().Config
+ config.DisableRestProtocolURICleaning = aws.Bool(true)
+
+ return s3.New(client.Session.Copy(&config))
 }
 
 // SetHTTPClient sets the http.Client used for AWS API calls.

diff --git a/internal/conns/awsclient_gen.go b/internal/conns/awsclient_gen.go
diff --git a/internal/conns/config.go b/internal/conns/config.go
@@ -218,9 +218,6 @@ func (c *Config) ConfigureProvider(ctx context.Context, client *AWSClient) (*AWS
  }
  client.s3Conn = s3.New(sess.Copy(s3Config))
 
- s3Config.DisableRestProtocolURICleaning = aws.Bool(true)
- client.s3ConnURICleaningDisabled = s3.New(sess.Copy(s3Config))
-
  // "Global" services that require customizations.
  globalAcceleratorConfig := &aws.Config{
  Endpoint: aws.String(c.Endpoints[names.GlobalAccelerator]),

diff --git a/internal/generate/awsclient/file.tmpl b/internal/generate/awsclient/file.tmpl
@@ -45,8 +45,6 @@ type AWSClient struct {
  {{ .ProviderPackage }}Client *{{ .GoV2Package }}.{{ .ClientTypeName }}
  {{- end }}
 {{- end }}
-
- s3ConnURICleaningDisabled *s3.S3
 }
 
 {{ range .Services }}

diff --git a/internal/service/acmpca/certificate.go b/internal/service/acmpca/certificate.go
@@ -341,7 +341,7 @@ func expandValidity(l []interface{}) (*acmpca.Validity, error) {
 
  i, err := ExpandValidityValue(valueType, m["value"].(string))
  if err != nil {
- return nil, fmt.Errorf("error parsing value %q: %w", m["value"].(string), err)
+ return nil, fmt.Errorf("parsing value %q: %w", m["value"].(string), err)
  }
  result.Value = aws.Int64(i)
 

diff --git a/internal/service/amp/find.go b/internal/service/amp/find.go
@@ -40,7 +40,7 @@ func FindAlertManagerDefinitionByID(ctx context.Context, conn *prometheusservice
 func nameAndWorkspaceIDFromRuleGroupNamespaceARN(arn string) (string, string, error) {
  parts := strings.Split(arn, "/")
  if len(parts) != 3 {
- return "", "", fmt.Errorf("error reading Prometheus Rule Group Namespace expected the arn to be like: arn:PARTITION:aps:REGION:ACCOUNT:rulegroupsnamespace/IDstring/namespace_name but got: %s", arn)
+ return "", "", fmt.Errorf("reading Prometheus Rule Group Namespace expected the arn to be like: arn:PARTITION:aps:REGION:ACCOUNT:rulegroupsnamespace/IDstring/namespace_name but got: %s", arn)
  }
  return parts[2], parts[1], nil
 }

diff --git a/internal/service/appconfig/deployment.go b/internal/service/appconfig/deployment.go
@@ -199,7 +199,7 @@ func DeploymentParseID(id string) (string, string, int, error) {
 
  num, err := strconv.Atoi(parts[2])
  if err != nil {
- return "", "", 0, fmt.Errorf("error parsing AppConfig Deployment resource ID deployment_number: %w", err)
+ return "", "", 0, fmt.Errorf("parsing AppConfig Deployment resource ID deployment_number: %w", err)
  }
 
  return parts[0], parts[1], num, nil

diff --git a/internal/service/appconfig/hosted_configuration_version.go b/internal/service/appconfig/hosted_configuration_version.go
@@ -191,7 +191,7 @@ func HostedConfigurationVersionParseID(id string) (string, string, int, error) {
 
  version, err := strconv.Atoi(parts[2])
  if err != nil {
- return "", "", 0, fmt.Errorf("error parsing Hosted Configuration Version version_number: %w", err)
+ return "", "", 0, fmt.Errorf("parsing Hosted Configuration Version version_number: %w", err)
  }
 
  return parts[0], parts[1], version, nil