Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect validation for heterogeneous list #1884

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Dec 3, 2024

This PR brings in the following changes from hcl-lang:

The local a is a tuple with specific element types. The for-expression has an empty tuple as a constraint, which doesn't match the specific element types. We now short-circuit the convertible check and always mark empty tuples as matching.

UX Before

CleanShot 2024-12-03 at 14 44 10@2x

UX After

CleanShot 2024-12-03 at 14 44 27@2x

Fixes hashicorp/vscode-terraform#1708

@dbanck dbanck added the bug Something isn't working label Dec 3, 2024
@dbanck dbanck requested a review from a team as a code owner December 3, 2024 13:47
@ansgarm ansgarm merged commit d511ad2 into main Dec 3, 2024
22 checks passed
@ansgarm ansgarm deleted the c-bump-hcl-lang branch December 3, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"no declaration found" for heteregeneous list
2 participants