Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Enable db param for RPO for RDS Aurora" #339

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Revert "Enable db param for RPO for RDS Aurora" #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions examples/standalone-aurora/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ module "standalone_aurora" {
aurora_cluster_instance_enable_single = var.aurora_cluster_instance_enable_single
aurora_db_password = var.aurora_db_password
aurora_db_username = var.aurora_db_username
aurora_parameter_group_family = var.aurora_parameter_group_family
aurora_global_db_rpo = var.aurora_global_db_rpo

ami_id = data.aws_ami.ubuntu.id
bypass_preflight_checks = true
Expand Down
12 changes: 0 additions & 12 deletions examples/standalone-aurora/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,3 @@ variable "aurora_cluster_instance_replica_count" {
type = number
description = "Number of extra cluster instances to create. Should be 0 if `aurora_cluster_instance_enable_single` is set to `true`."
}

variable "aurora_global_db_rpo" {
type = string
description = "Value of the RPO for the Aurora global database."
default = "55"
}

variable "aurora_parameter_group_family" {
type = string
description = "RDS cluster parameter group"
default = "aurora-postgresql16"
}
2 changes: 0 additions & 2 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,6 @@ module "aurora_database" {
aurora_db_password = var.aurora_db_password
aurora_cluster_instance_replica_count = var.aurora_cluster_instance_replica_count
aurora_cluster_instance_enable_single = var.aurora_cluster_instance_enable_single
aurora_global_db_rpo = var.aurora_global_db_rpo
aurora_parameter_group_family = var.aurora_parameter_group_family

db_backup_retention = var.aurora_db_backup_retention
db_backup_window = var.db_backup_window
Expand Down
11 changes: 0 additions & 11 deletions modules/aurora_database_cluster/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,3 @@ resource "aws_rds_cluster_instance" "cluster_instances_n" {
engine = aws_rds_cluster.aurora_postgresql.engine
engine_version = aws_rds_cluster.aurora_postgresql.engine_version
}

resource "aws_rds_cluster_parameter_group" "default" {
name = "aurora-postgresql"
family = var.aurora_parameter_group_family
description = "RDS cluster parameter group"

parameter {
name = "rds.global_db_rpo"
value = var.aurora_global_db_rpo
}
}
12 changes: 0 additions & 12 deletions modules/aurora_database_cluster/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,6 @@ variable "aurora_cluster_instance_enable_single" {
description = "Creates a single rds cluster instance."
}

variable "aurora_global_db_rpo" {
type = string
description = "Value of the RPO for the Aurora global database."
default = "55"
}

variable "aurora_parameter_group_family" {
type = string
description = "RDS cluster parameter group"
default = "aurora-postgresql16"
}

variable "engine_version" {
type = string
description = "PostgreSQL version."
Expand Down
12 changes: 0 additions & 12 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,18 +237,6 @@ variable "aurora_db_username" {
}
}

variable "aurora_global_db_rpo" {
type = string
description = "Value of the RPO for the Aurora global database."
default = "55"
}

variable "aurora_parameter_group_family" {
type = string
description = "RDS cluster parameter group"
default = "aurora-postgresql16"
}

variable "aurora_postgres_engine_version" {
type = string
default = "16.2"
Expand Down
Loading