generator-go-sdk: support model behaviors #4436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iscriminated value when marshalling), enable for MS Graph
manicminer
added
enhancement
stephybun
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Thanks @manicminer other than a suggestion on the naming and the comment LGTM 🍜
Comment on lines
77
to
78
| // whether model behaviors are enabled | ||
| enableModelBehaviors bool |
There was a problem hiding this comment.
Could this have a more descriptive name for what it does? I don't see why we couldn't name this omitDiscriminatedValue with more detail in the comment
Suggested change
| // whether model behaviors are enabled | |
| enableModelBehaviors bool | |
| // whether the discriminated field should be omitted from a model and thus ignored in the marshalling/unmarshalling of the struct, this currently only applies to MS Graph models | |
| omitDiscriminatedValue bool |
…mprove doc comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial behavior to omit discriminated value when marshalling. Model behaviors are opt-in; enabled only for MS Graph at this time.
Example SDK Output