generator-go-sdk: fix unmarshalling fields that reference a model interface #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erface (rather than a model struct)
manicminer
added
bug
…rfaces are unmarshalled correctly
stephybun
approved these changes
Sep 23, 2024
| } | ||
| } | ||
|
|
||
| fieldTypeName := "FIXME" |
There was a problem hiding this comment.
Is there any context on this?
There was a problem hiding this comment.
This is a holdover, we should probably be erroring here rather than outputting FIXME strings, I'll look to fix that up 👍
manicminer
deleted the
generator-go-sdk/fix-unmarshalling-member-interfaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a model fields references an interface (i.e. a parent model), this currently fails to unmarshal. This PR fixes that by generating a temporary struct minus those such fields, unmarshalling into it, and then calling the explicit
Unmarshal{Foo}Implementationfunction for that model.Additionally, make the
Unmarshal{Foo}Implementationfunctions more forgiving, so if the discriminated value field is missing, it continues to unmarshal into, and return, aRaw{Foo}Implstruct instead of just returning nil.