-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate a Microsoft Graph SDK #4346
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of trying to work it out for each model
… to prevent naming conflicts with annoyingly named models
…creating lots of files in a directory
…ls in operations and predicates
… it matches the service name
…n it matches the service name
…/unsupported naming
…er than the resource name
…itions for common types generator
…nceNameIsCommonType is set for model fields
…t odata, query and header options
…on between `/members/$ref` and `/members/{id}/$ref`
… resource ID segments
…criminated/child models
…ecified resource ID segments
… again causes clobbering
…TypeBeforeSegment` method
stephybun
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @manicminer LGTM 🍇
…cklist since this is now covered by workarounds
Breaking ChangesNo Breaking Changes were found 👍 |
Summary of ChangesNo Breaking or Non-Breaking Changes were found 👍 |
New Resource ID Segments containing Static IdentifiersNo new Resource ID Segments containing Static Identifiers were identified in the set of changes 🤙. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/acceptance-tests
area/discriminators
Discriminators are interface/implementations
area/resource-identification
Related to the Identification/Processing of Resources
area/resource-ids
Related to Resource IDs, Parsers and Formatters
go
Pull requests that update Go code
tool/data-api
Issues with the Data API
tool/generator-go-sdk
Issues with the Go SDK Generator
tool/generator-terraform
Issues with the Terraform Generator
tool/internal-sdk
Related to the internal SDK used in this repository `./tools/sdk`
tool/msgraph-importer
Issues related to the Microsoft Graph importer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: hashicorp/go-azure-sdk#1058
This PR incorporates various fixes and improvements to both the MS Graph Importer and Go SDK Generator, enabling the generation of a Microsoft Graph SDK.
*interface{}
, these are nowinterface{}
. This affects Resource Manager and Microsoft Graph SDKs.Summary of Changes
Repository / Tooling
Go SDK Generator
go-azure-sdk/sdk/nullable
typesY-m-d[-preview]
conventionMS Graph Importer
msgraph-metadata
submodule@odata.id
and@odata.type
fields to every model@odata.bind
field forDirectoryObject
referencesmicrosoft.graph.
prefix on action URL suffixesApplication
modelConditionalAccessPolicy
to enable correct behavior with nullable fieldsSupported Services
Generated SDK Improvements
Comments for model fields
Comments for operation methods
Nullable fields support
Read-Only fields support
Ability to obtain an ancestor model representation for discriminated models
Support for OData options (headers and query params)
Outstanding Items
generator-go-sdk
resource-manager
SDK