Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/generator-go-sdk: fixing an issue where the environments import conflicts by aliasing it #2863

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jul 31, 2023

This fixes an issue where some API Resources are called Environments, which conflicts with the import for sdk/environments, used to define an Azure Environment

Fixes #2825
Fixes hashicorp/go-azure-sdk#580

…rt conflicts by alaising it

This fixes an issue where some API Resources are called `Environments`, which conflicts with the
import for `sdk/environments`, used to define an Azure Environment
@tombuildsstuff tombuildsstuff requested a review from a team July 31, 2023 15:32
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good workaround, LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 0a63691 into main Jul 31, 2023
1 check passed
@tombuildsstuff tombuildsstuff deleted the b/import-alias-for-environments branch July 31, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tools/generator-go-sdk: DevTestLab contains the API Resource Environments which conflicts at import time
2 participants