scheduler: fix a bug where force GC wasn't respected #24456
Conversation
| func (c *CoreScheduler) setCustomThresholdForAllObjects(threshold time.Duration) { | ||
| for _, objectName := range []string{ | ||
| "job", | ||
| "eval", | ||
| "batchEval", | ||
| "deployment", | ||
| "csiPlugin", | ||
| "csiVolume", | ||
| "token", | ||
| "node", | ||
| } { | ||
| c.setCustomThresholdForObject(objectName, threshold) | ||
| } | ||
| } |
There was a problem hiding this comment.
My main concern with this kind of approach is that we're relying on matching strings to tables/objects to funcs. If we add a new table, and remember to add a new GC func, we also have to remember adding this string. Since we don't add new gc-able objects often, it seems even more likely we'd forget the force gc path.
What if instead we passed the threshold into the funcs directly from Process? Process already does string parsing of the Eval (which is a different string than this map keys off of!), so I don't think it would make Process too much more complicated to pass the appropriate threshold from config into funcs. It might make testing easier to? You can pass thresholds in directly to gc funcs or you can customize the config. I would hope that would cover every case.
There was a problem hiding this comment.
Since we don't add new gc-able objects often, it seems even more likely we'd forget the force gc path.
That is, sadly, very likely.
What if instead we passed the threshold into the funcs directly from Process?
I looked at that but it's a major change. Not only would we have to change every call to Process (of which there are many), but we'd also need to change the scheduler interface. Not saying we shouldn't do this, just saying it's a big change.
There was a problem hiding this comment.
Not only would we have to change every call to Process
Do we have to change the Process call, or just change the code inside CoreScheduler.Process?
For example could the call to c.jobGC(eval) be changed to c.jobGC(eval, c.srv.config.JobGCThreshold) to avoid the config lookup inside jobGC itself?
This PR fixes a bug where
System.GarbageCollectendpoint didn't work on objects that weren't older than their respective GC thresholds.System.GarbageCollectis used to force garbage collection (also used by thesystem gccommand) and should ignore any GC threshold settings.Fixes #24455
Internal ref: https://hashicorp.atlassian.net/browse/NET-11747