Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start: allow users to call job start command to start stopped jobs #24150
base: main
Are you sure you want to change the base?
start: allow users to call job start command to start stopped jobs #24150
Changes from 4 commits
bb347a1
a5e5c66
a36a5d8
0d0740f
6d43620
f2da6d4
35e15db
8f0e67b
150ad92
5126d67
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we don't have any clue here to the user that they can use more than one job ID, or that if they do they all need to be in the same namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jobID := range jobIDs
is the ideomatic way to write this, but in the goroutine we shadow this variable. That makes it easy to confuse whether we're dealing with the prefix we got from the user or the actual job ID we got from ourJobIDByPrefix
call. That results in a small bug later down.Also, as of Go 1.22 we no longer need to rebind the loopvar, so we're free of having to remember! I always forget 😊 so good that you caught it, but we can drop it now. See https://go.dev/wiki/LoopvarExperiment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooh I didn't know that! Thanks for catching this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is where we originally shadowed
jobID
, but as it turns out we're not actually shadowing it because we changed the capitalization. This makes it really easy to miss that we're using the prefix when we make theJobs().Versions
call later.But it turns out that we already need to call
JobByPrefix
below, which takes the prefix, so we can just delete this whole block.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.