Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add python stdio implement #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions client.go
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,8 @@ func (c *Client) Client() (ClientProtocol, error) {
c.client, err = newRPCClient(c)

case ProtocolGRPC:
//c.client, err = newRPCClient(c)
//
c.client, err = newGRPCClient(c.doneCtx, c)

default:
Expand Down
2 changes: 1 addition & 1 deletion examples/grpc/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,5 @@ $ protoc -I proto/ proto/kv.proto --go_out=plugins=grpc:proto/
For Python:

```sh
$ python -m grpc_tools.protoc -I ./proto/ --python_out=./plugin-python/ --grpc_python_out=./plugin-python/ ./proto/kv.proto
$ python -m grpc_tools.protoc -I ./proto/ --python_out=./plugin-python/ --grpc_python_out=./plugin-python/ ./proto/kv.proto ./proto/grpc_stdio.proto
```
1 change: 1 addition & 0 deletions examples/grpc/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ func main() {
client := plugin.NewClient(&plugin.ClientConfig{
HandshakeConfig: shared.Handshake,
Plugins: shared.PluginMap,
SyncStdout: os.Stdout,
Cmd: exec.Command("sh", "-c", os.Getenv("KV_PLUGIN")),
AllowedProtocols: []plugin.Protocol{
plugin.ProtocolNetRPC, plugin.ProtocolGRPC},
Expand Down
22 changes: 22 additions & 0 deletions examples/grpc/plugin-python/client.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@

import kv_pb2
import kv_pb2_grpc


import grpc



def run():
# NOTE(gRPC Python Team): .close() is possible on a channel and should be
# used in circumstances in which the with statement does not fit the needs
# of the code.
with grpc.insecure_channel('localhost:1234') as channel:
stub = kv_pb2_grpc.KVStub(channel)
stub.Put(kv_pb2.PutRequest(key="cc",value=b"1"))
response = stub.Get(kv_pb2.GetRequest(key="cc"))

print("Greeter client received: " + str(response.value))

if __name__ == '__main__':
run()
42 changes: 42 additions & 0 deletions examples/grpc/plugin-python/grpc_stdio_pb2.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

81 changes: 81 additions & 0 deletions examples/grpc/plugin-python/grpc_stdio_pb2_grpc.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
# Generated by the gRPC Python protocol compiler plugin. DO NOT EDIT!
"""Client and server classes corresponding to protobuf-defined services."""
import grpc

from google.protobuf import empty_pb2 as google_dot_protobuf_dot_empty__pb2
import grpc_stdio_pb2 as grpc__stdio__pb2


class GRPCStdioStub(object):
"""GRPCStdio is a service that is automatically run by the plugin process
to stream any stdout/err data so that it can be mirrored on the plugin
host side.
"""

def __init__(self, channel):
"""Constructor.

Args:
channel: A grpc.Channel.
"""
self.StreamStdio = channel.unary_stream(
'/plugin.GRPCStdio/StreamStdio',
request_serializer=google_dot_protobuf_dot_empty__pb2.Empty.SerializeToString,
response_deserializer=grpc__stdio__pb2.StdioData.FromString,
)


class GRPCStdioServicer(object):
"""GRPCStdio is a service that is automatically run by the plugin process
to stream any stdout/err data so that it can be mirrored on the plugin
host side.
"""

def StreamStdio(self, request, context):
"""StreamStdio returns a stream that contains all the stdout/stderr.
This RPC endpoint must only be called ONCE. Once stdio data is consumed
it is not sent again.

Callers should connect early to prevent blocking on the plugin process.
"""
context.set_code(grpc.StatusCode.UNIMPLEMENTED)
context.set_details('Method not implemented!')
raise NotImplementedError('Method not implemented!')


def add_GRPCStdioServicer_to_server(servicer, server):
rpc_method_handlers = {
'StreamStdio': grpc.unary_stream_rpc_method_handler(
servicer.StreamStdio,
request_deserializer=google_dot_protobuf_dot_empty__pb2.Empty.FromString,
response_serializer=grpc__stdio__pb2.StdioData.SerializeToString,
),
}
generic_handler = grpc.method_handlers_generic_handler(
'plugin.GRPCStdio', rpc_method_handlers)
server.add_generic_rpc_handlers((generic_handler,))


# This class is part of an EXPERIMENTAL API.
class GRPCStdio(object):
"""GRPCStdio is a service that is automatically run by the plugin process
to stream any stdout/err data so that it can be mirrored on the plugin
host side.
"""

@staticmethod
def StreamStdio(request,
target,
options=(),
channel_credentials=None,
call_credentials=None,
insecure=False,
compression=None,
wait_for_ready=None,
timeout=None,
metadata=None):
return grpc.experimental.unary_stream(request, target, '/plugin.GRPCStdio/StreamStdio',
google_dot_protobuf_dot_empty__pb2.Empty.SerializeToString,
grpc__stdio__pb2.StdioData.FromString,
options, channel_credentials,
insecure, call_credentials, compression, wait_for_ready, timeout, metadata)
Loading