Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk/client: conditionally return the error when the resp is nil whilst retrying the request #970

Merged
merged 1 commit into from
Apr 22, 2024
Merged

sdk/client: conditionally return the error when the resp is nil whilst retrying the request #970

merged 1 commit into from
Apr 22, 2024

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer added bug Something isn't working base-layer labels Apr 19, 2024
@manicminer manicminer requested a review from a team as a code owner April 19, 2024 12:47
@github-actions github-actions bot added the release-once-merged The SDK should be released once this PR is merged label Apr 19, 2024
catriona-m
catriona-m approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manicminer manicminer merged commit 48bcf22 into main Apr 22, 2024
6 checks passed
@manicminer manicminer deleted the bugfix/error-dropping-on-retry branch April 22, 2024 11:14
@manicminer manicminer mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catriona-m catriona-m catriona-m approved these changes

Assignees
No one assigned
Labels
base-layer bug Something isn't working release-once-merged The SDK should be released once this PR is merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manicminer @catriona-m