Metadata fixes #960
Merged
Metadata fixes #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release-once-merged
…include MS Graph and will no longer work with Terraform providers
…resource IDs for public, usgov and china
manicminer
force-pushed
the
metadata-fixes
branch
from
d7b58d2
to
37e02a9
Compare
tombuildsstuff
approved these changes
Apr 11, 2024
sdk/environments/azure_china.go
Outdated
Comment on lines
41
to
44
| env.Attestation = applicationIdOnly("AttestationService", attestationServiceAppId) | ||
| env.CDNFrontDoor = applicationIdOnly("CDNFrontDoor", cdnFrontDoorAppId) | ||
| env.DataLake = applicationIdOnly("DataLake", dataLakeAppId) | ||
| env.IoTCentral = applicationIdOnly("IoTCentral", iotCentralAppId) |
There was a problem hiding this comment.
these are applicationIdOnly by default if not configured, so we should be able to remove these?
Suggested change
| env.Attestation = applicationIdOnly("AttestationService", attestationServiceAppId) | |
| env.CDNFrontDoor = applicationIdOnly("CDNFrontDoor", cdnFrontDoorAppId) | |
| env.DataLake = applicationIdOnly("DataLake", dataLakeAppId) | |
| env.IoTCentral = applicationIdOnly("IoTCentral", iotCentralAppId) |
sdk/environments/azure_gov.go
Outdated
Comment on lines
40
to
44
| // Services not currently available: Attestation, CDNFrontDoor, DataLake, IOTCentral | ||
| env.Attestation = applicationIdOnly("AttestationService", attestationServiceAppId) | ||
| env.CDNFrontDoor = applicationIdOnly("CDNFrontDoor", cdnFrontDoorAppId) | ||
| env.DataLake = applicationIdOnly("DataLake", dataLakeAppId) | ||
| env.IoTCentral = applicationIdOnly("IoTCentral", iotCentralAppId) |
There was a problem hiding this comment.
(same)
Suggested change
| // Services not currently available: Attestation, CDNFrontDoor, DataLake, IOTCentral | |
| env.Attestation = applicationIdOnly("AttestationService", attestationServiceAppId) | |
| env.CDNFrontDoor = applicationIdOnly("CDNFrontDoor", cdnFrontDoorAppId) | |
| env.DataLake = applicationIdOnly("DataLake", dataLakeAppId) | |
| env.IoTCentral = applicationIdOnly("IoTCentral", iotCentralAppId) |
sdk/environments/environment.go
Outdated
Comment on lines
163
to
166
| func (e *ApiEndpoint) WithResourceIdentifier(identifier string) Api { | ||
| e.resourceIdentifier = pointer.To(identifier) | ||
| return e | ||
| } |
There was a problem hiding this comment.
Since there's talk of overriding the token below on a per-Storage Account basis - perhaps this should return a new instance of Api rather than mutating the existing object, to ensure this is a clean-copy?
There was a problem hiding this comment.
Good idea, will do that 👍
…point` rather than mutating the existing one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This must be merged in tandem with hashicorp/terraform-provider-azurerm#25546, to avoid breaking
storage