enhancement: include HTTP status text in error when response is unexpected #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release-once-merged
manicminer
force-pushed
the
enhancement/http-status-text-in-error
branch
from
50a5c32
to
7708940
Compare
tombuildsstuff
approved these changes
Mar 20, 2024
sdk/client/client.go
Outdated
| // Note that the odata argument here is a best-effort and may be nil | ||
| if f := req.ValidStatusFunc; f != nil && f(resp.Response, resp.OData) { | ||
| return resp, nil | ||
| } | ||
|
|
||
| status := fmt.Sprintf("%d", resp.StatusCode) | ||
| if statusText := http.StatusText(resp.StatusCode); statusText != "" { |
There was a problem hiding this comment.
Azure doesn't always use the Status Code to mean what the HTTP status means, but the HTTP Status Text is returned along side this, so we should be able to make this:
Suggested change
| if statusText := http.StatusText(resp.StatusCode); statusText != "" { | |
| if statusText := resp.Status; statusText != nil { |
manicminer
force-pushed
the
enhancement/http-status-text-in-error
branch
from
7708940
to
0f5aa12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvement, but adds a small amount of context mainly useful in the case that the API returns no error text.