Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poller: retry LRO polling if 404 response received #913

Merged
merged 1 commit into from
Mar 1, 2024
Merged

poller: retry LRO polling if 404 response received #913

merged 1 commit into from
Mar 1, 2024
+13 −5

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Mar 1, 2024 •
edited
Loading

Closes: #740

@manicminer manicminer requested a review from a team as a code owner March 1, 2024 00:29
@github-actions github-actions bot added the release-once-merged The SDK should be released once this PR is merged label Mar 1, 2024
@manicminer manicminer changed the title poller: retry LRO polling if 404 response received, closes #740 poller: retry LRO polling if 404 response received Mar 1, 2024
tombuildsstuff
tombuildsstuff approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer merged commit 5bb1066 into main Mar 1, 2024
6 checks passed
@manicminer manicminer deleted the polling/retry-lro-poller-on-404 branch March 1, 2024 11:08
@sinbai sinbai mentioned this pull request Apr 10, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
base-layer/polling release-once-merged The SDK should be released once this PR is merged
Projects
None yet
Milestone
No milestone
2 participants
@manicminer @tombuildsstuff