Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk/client/resourcemanager supporting Patching as a provisioningState value for NetApp #888

Merged
merged 2 commits into from
Feb 19, 2024
Merged

sdk/client/resourcemanager supporting Patching as a provisioningState value for NetApp #888

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f441c6e
`sdk/client/resourcemanager`: supporting `Patching` as an undocumente…
tombuildsstuff Feb 19, 2024
c420f1b
`sdk/client/resourcemanager`: sorting the unexpected statuses alphabe…
tombuildsstuff Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 38 additions & 13 deletions sdk/client/resourcemanager/poller_lro.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,47 +164,72 @@ func (p *longRunningOperationPoller) Poll(ctx context.Context) (result *pollers.
// whilst the standard set above should be sufficient, some APIs differ from the spec and should be documented below:
// Dashboard@2022-08-01 returns `Accepted` rather than `InProgress` during creation
"Accepted": pollers.PollingStatusInProgress,

// EventGrid@2022-06-15 returns `Active` rather than `InProgress` during creation
"Active": pollers.PollingStatusInProgress,

// NetAppVolumeReplication @ 2023-05-01 returns `AuthorizeReplication` during authorizing replication
"AuthorizeReplication": pollers.PollingStatusInProgress,

// NetAppVolumeReplication @ 2023-05-01 returns `BreakReplication` during breaking replication
"BreakReplication": pollers.PollingStatusInProgress,

// Mysql @ 2022-01-01 returns `CancelInProgress` during Update
"CancelInProgress": pollers.PollingStatusInProgress,

// CostManagement@2021-10-01 returns `Completed` rather than `Succeeded`: https://github.com/Azure/azure-sdk-for-go/issues/20342
"Completed": pollers.PollingStatusSucceeded,

// ServiceFabricManaged @ 2021-05-01 (NodeTypes CreateOrUpdate) returns `Created` rather than `InProgress` during Creation
"Created": pollers.PollingStatusInProgress,

// ContainerRegistry@2019-06-01-preview returns `Creating` rather than `InProgress` during creation
"Creating": pollers.PollingStatusInProgress,
// SignalR@2022-02-01 returns `Running` rather than `InProgress` during creation
"Running": pollers.PollingStatusInProgress,
// KubernetesConfiguration@2022-11-01 returns `Updating` rather than `InProgress` during update
"Updating": pollers.PollingStatusInProgress,
// StorageSync@2020-03-01 returns `validateInput`, `newPrivateDnsEntries`, `finishNewStorageSyncService` rather than `InProgress` during creation/update
// See: https://github.com/hashicorp/go-azure-sdk/issues/565
"validateInput": pollers.PollingStatusInProgress,
"newPrivateDnsEntries": pollers.PollingStatusInProgress,

// StorageSync@2020-03-01 returns `finishNewStorageSyncService` rather than `InProgress` during creation/update (https://github.com/hashicorp/go-azure-sdk/issues/565)
"finishNewStorageSyncService": pollers.PollingStatusInProgress,

// StorageSync@2020-03-01 returns `newManagedIdentityCredentialStep` rather than `InProgress` during creation/update (https://github.com/hashicorp/go-azure-sdk/issues/565)
"newManagedIdentityCredentialStep": pollers.PollingStatusInProgress,
"finishNewStorageSyncService": pollers.PollingStatusInProgress,
// StorageSync@2020-03-01 (CloudEndpoints) returns `newReplicaGroup` rather than `InProgress` during creation/update
// See: https://github.com/hashicorp/go-azure-sdk/issues/565

// StorageSync@2020-03-01 returns `newPrivateDnsEntries` rather than `InProgress` during creation/update (https://github.com/hashicorp/go-azure-sdk/issues/565)
"newPrivateDnsEntries": pollers.PollingStatusInProgress,

// StorageSync@2020-03-01 (CloudEndpoints) returns `newReplicaGroup` rather than `InProgress` during creation/update (https://github.com/hashicorp/go-azure-sdk/issues/565)
"newReplicaGroup": pollers.PollingStatusInProgress,
// SAPVirtualInstance @ 2023-04-01 returns `Preparing System Configuration` during Creation
"Preparing System Configuration": pollers.PollingStatusInProgress,

// NetApp @ 2023-05-01 (Volume Update) returns `Patching` during Update
"Patching": pollers.PollingStatusInProgress,

// AnalysisServices @ 2017-08-01 (Servers Suspend) returns `Pausing` during update
"Pausing": pollers.PollingStatusInProgress,

// SAPVirtualInstance @ 2023-04-01 returns `Preparing System Configuration` during Creation
"Preparing System Configuration": pollers.PollingStatusInProgress,

// AnalysisServices @ 2017-08-01 (Servers) returns `Provisioning` during Creation
"Provisioning": pollers.PollingStatusInProgress,

// Resources @ 2020-10-01 (DeploymentScripts) returns `ProvisioningResources` during Creation
"ProvisioningResources": pollers.PollingStatusInProgress,

// AnalysisServices @ 2017-08-01 (Servers Resume) returns `Resuming` during Update
"Resuming": pollers.PollingStatusInProgress,

// SignalR@2022-02-01 returns `Running` rather than `InProgress` during creation
"Running": pollers.PollingStatusInProgress,

// AnalysisServices @ 2017-08-01 (Servers Suspend) returns `Scaling` during Update
"Scaling": pollers.PollingStatusInProgress,

// KubernetesConfiguration@2022-11-01 returns `Updating` rather than `InProgress` during update
"Updating": pollers.PollingStatusInProgress,

// HealthBot @ 2022-08-08 (HealthBots CreateOrUpdate) returns `Working` during Creation
"Working": pollers.PollingStatusInProgress,

// StorageSync@2020-03-01 returns `validateInput` rather than `InProgress` during creation/update (https://github.com/hashicorp/go-azure-sdk/issues/565)
"validateInput": pollers.PollingStatusInProgress,
}
for k, v := range statuses {
if strings.EqualFold(string(op.Properties.ProvisioningState), string(k)) {
Expand Down
Loading