sdk: check for empty response body before unmarshalling #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release-once-merged
tombuildsstuff
approved these changes
Feb 9, 2024
Comment on lines
+192
to
+195
| // In some cases the respBody is empty, but not nil, so don't attempt to unmarshal this | ||
| if len(respBody) == 0 { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Mind implementing the same fix for XML deserialization too (but not for the bytes deserialization, which'd want that context)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug with Maintenance Delete where the response body is empty, but not nil, so this does not get unmarshalled.