Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poller: add Created as inprogress status for fabric managed #871

Merged
merged 2 commits into from
Feb 2, 2024
Merged

poller: add Created as inprogress status for fabric managed #871

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19d5ceb
add created as inprogress status for fabric managed
wuxu92 Feb 2, 2024
0795d1c
resort status
wuxu92 Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/client/resourcemanager/poller_lro.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,8 @@ func (p *longRunningOperationPoller) Poll(ctx context.Context) (result *pollers.
"Scaling": pollers.PollingStatusInProgress,
// HealthBot @ 2022-08-08 (HealthBots CreateOrUpdate) returns `Working` during Creation
"Working": pollers.PollingStatusInProgress,
// ServiceFabricManaged @ 2021-05-01 (NodeTypes CreateOrUpdate) returns `Created` rather than `InProgress` during Creation
"Created": pollers.PollingStatusInProgress,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to double-check, Created is used to mean InProgress rather than Succeeded?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor, but could we also move this up, since the other keys are sorted alphabetically)

Copy link
Contributor Author

@wuxu92 wuxu92 Feb 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Created means InProgress which I have verified locally. The poller will stop with a Succeeded response:
image

also moved up.

}
for k, v := range statuses {
if strings.EqualFold(string(op.Properties.ProvisioningState), string(k)) {
Expand Down
Loading