Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Modules Part 3 - microsoft-graph/ #844

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

tombuildsstuff
Copy link
Contributor

This PR is part 3 of adding Nested Go Modules - adding the ./microsoft-graph/ Go Module.

Once merged this likely wants to be manually released first - at which point we should be able to re-enable the automation.

At this point this Go Module is purely being scaffolded out / contains nothing usable - but will in the future - as such enabling automation here from the start allows us to use this as soon as it's available.

Part of hashicorp/pandora#3601

Dependent on #843

@github-actions github-actions bot added the release-once-merged The SDK should be released once this PR is merged label Jan 24, 2024
@tombuildsstuff tombuildsstuff changed the title Go Modules Part 3 - .microsoft-graph/ Go Modules Part 3 - microsoft-graph/ Jan 24, 2024
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍉

@tombuildsstuff tombuildsstuff marked this pull request as ready for review January 25, 2024 10:24
@tombuildsstuff tombuildsstuff requested a review from a team as a code owner January 25, 2024 10:24
@tombuildsstuff tombuildsstuff merged commit f1a3136 into main Jan 25, 2024
3 checks passed
@tombuildsstuff tombuildsstuff deleted the f/submodules-3-microsoft-graph branch January 25, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-once-merged The SDK should be released once this PR is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants