Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automation: splitting the determining and publishing of the Git Tag #834

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

tombuildsstuff
Copy link
Contributor

This is needed as a part of hashicorp/pandora#3601 since we're going to be publishing multiple Go Modules at different paths - but the version number of each of them is going to be the same.

As such this PR splits the determining and publishing of the Git Tag - such that the existing update tooling continues to work with minor changes (tracked in hashicorp/terraform-provider-azurerm#24602).

Given this is a Github Action this is hard to test locally - I've tested the scripts (which are fine) - but I suspect this change should be fine to merge today, prior to enabling module support.

This is needed as a part of hashicorp/pandora#3601 since we're going to be publishing
multiple Go Modules at different paths - but the version number of each of them is going to be the same.

As such this PR splits the determining and publishing of the Git Tag - such that the existing update tooling
continues to work with minor changes (tracked in hashicorp/terraform-provider-azurerm#24602)
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added the release-once-merged The SDK should be released once this PR is merged label Jan 23, 2024
@tombuildsstuff tombuildsstuff merged commit 9c3ff86 into main Jan 23, 2024
4 checks passed
@tombuildsstuff tombuildsstuff deleted the f/splitting-version-number-generation branch January 23, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-once-merged The SDK should be released once this PR is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants