Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/resourcemanager: handling self-referenced LROs #590

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

tombuildsstuff
Copy link
Contributor

Some LROs return a 201 with the Location header as a self-reference, polling on that URI returns a 200 OK with no provisioningState or status field to poll on - as such we need to special-case to handle this.

Fixes an issue in Automation @ 2022-08-08 in DSCNodeConfiguration / CreateOrUpdate

Fixes hashicorp/terraform-provider-azurerm#22781

Some LROs return a 201 with the Location header as a self-reference, polling on that URI returns a 200 OK with
no provisioningState or status field to poll on - as such we need to special-case to handle this.

Fixes an issue in `Automation` @ `2022-08-08` in `DSCNodeConfiguration` / `CreateOrUpdate`
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧇

@tombuildsstuff tombuildsstuff added the release-once-merged The SDK should be released once this PR is merged label Aug 2, 2023
@tombuildsstuff tombuildsstuff merged commit e6e8e2b into main Aug 2, 2023
5 checks passed
@tombuildsstuff tombuildsstuff deleted the b/poller-automation-dscnodeconfiguration branch August 2, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base-layer/polling release-once-merged The SDK should be released once this PR is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants