Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.17 upgrade-specific note for upstream normalization. #19181

Merged
merged 8 commits into from
Oct 12, 2023

Conversation

hashi-derek
Copy link
Member

Add Enterprise upgrade-specific note for: #19076

@hashi-derek hashi-derek added the backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. label Oct 12, 2023
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Oct 12, 2023
@hashi-derek hashi-derek marked this pull request as ready for review October 12, 2023 19:45
@hashi-derek hashi-derek requested a review from a team as a code owner October 12, 2023 19:45
@hashi-derek hashi-derek added the pr/no-changelog PR does not need a corresponding .changelog entry label Oct 12, 2023
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tweaks for consistency with our writing styles

website/content/docs/upgrading/upgrade-specific.mdx Outdated Show resolved Hide resolved
website/content/docs/upgrading/upgrade-specific.mdx Outdated Show resolved Hide resolved
website/content/docs/upgrading/upgrade-specific.mdx Outdated Show resolved Hide resolved
website/content/docs/upgrading/upgrade-specific.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM!

Suggestions are to align with style guide. Let me know if you have any questions!

Approving on behalf of consul-docs.

website/content/docs/upgrading/upgrade-specific.mdx Outdated Show resolved Hide resolved
website/content/docs/upgrading/upgrade-specific.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@Jeff-Apple Jeff-Apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hashi-derek
Copy link
Member Author

hashi-derek commented Oct 12, 2023

@trujillo-adam @boruszak can you please take a second glance at this? I mixed both of your suggestions together and made some minor tweaks to ensure the idea was still conveyed properly.

Copy link
Contributor

@boruszak boruszak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

website/content/docs/upgrading/upgrade-specific.mdx Outdated Show resolved Hide resolved
website/content/docs/upgrading/upgrade-specific.mdx Outdated Show resolved Hide resolved
@hashi-derek hashi-derek enabled auto-merge (squash) October 12, 2023 20:23
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. pr/no-changelog PR does not need a corresponding .changelog entry type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants