Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update solo to support pathPrefix of mirror node importer #1204

Merged
merged 15 commits into from
Jan 27, 2025
Merged

feat: update solo to support pathPrefix of mirror node importer #1204

merged 15 commits into from
Jan 27, 2025
+61 −19

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Jan 23, 2025 •
edited
Loading

Description

This pull request changes the following:

  • Add flag storageBucketPrefix
  • update solo to support pathPrefix of mirror node importer

Related Issues

@JeffreyDallas
save
fd9fd68 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
add flag for mirror downloader prefix
fc294b6 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
save
6028a28 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
Save
d18d670 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
fix script typo
e848216 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas JeffreyDallas requested review from a team and leninmehedy as code owners January 23, 2025 16:41
@JeffreyDallas JeffreyDallas self-assigned this Jan 23, 2025
@JeffreyDallas JeffreyDallas marked this pull request as draft January 23, 2025 16:42
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

Unit Test Results - Linux

  1 files   59 suites   3s ⏱️
233 tests 233 ✅ 0 💤 0 ❌
238 runs  238 ✅ 0 💤 0 ❌

Results for commit e06d070.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025 •
edited
Loading

Unit Test Results - Windows

  1 files   59 suites   13s ⏱️
233 tests 233 ✅ 0 💤 0 ❌
238 runs  238 ✅ 0 💤 0 ❌

Results for commit e06d070.

♻️ This comment has been updated with latest results.

@JeffreyDallas
save
eb6d83c 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
save
a465c6f 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
revert change of checkout solo-chart
eb4dc83 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
bump mirror chart version
2c1d553 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
fix backup bucket prefix
de1edf0 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
save
27e6429 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
save
51a87bc 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas
add force option
5a67f3a 
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas JeffreyDallas reopened this Jan 24, 2025
@JeffreyDallas JeffreyDallas marked this pull request as ready for review January 24, 2025 19:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 24, 2025 •
edited
Loading

E2E Test Report

 17 files  126 suites   1h 30m 0s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
269 runs  269 ✅ 0 💤 0 ❌

Results for commit e06d070.

♻️ This comment has been updated with latest results.

@codacy-production Codacy Production
Copy link

codacy-production bot commented Jan 24, 2025 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 764db3a1 ✅ 82.14%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (764db3a) Report Missing Report Missing Report Missing
Head commit (e06d070) 21851 18306 83.78%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1204) 28 23 82.14%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.89%. Comparing base (d60247a) to head (e06d070).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/mirror_node.ts 33.33% 4 Missing ⚠️
src/commands/network.ts 75.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1204      +/-   ##
==========================================
- Coverage   82.89%   82.89%   -0.01%     
==========================================
  Files          78       79       +1     
  Lines       21763    21851      +88     
  Branches     1824     1469     -355     
==========================================
+ Hits        18041    18113      +72     
- Misses       3584     3700     +116     
+ Partials      138       38     -100
Files with missing lines Coverage Δ
src/commands/flags.ts 76.01% <100.00%> (+0.35%) ⬆️
version.ts 100.00% <100.00%> (ø)
src/commands/network.ts 65.86% <75.00%> (+0.07%) ⬆️
src/commands/mirror_node.ts 75.20% <33.33%> (-0.42%) ⬇️

... and 36 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon added the PR: Ready to Merge A pull request that is ready to merge. label Jan 27, 2025
@JeffreyDallas JeffreyDallas merged commit d9a3592 into main Jan 27, 2025
39 of 42 checks passed
@JeffreyDallas JeffreyDallas deleted the mirror-bukcet-prefix branch January 27, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner

@andrewb1269hg andrewb1269hg Awaiting requested review from andrewb1269hg andrewb1269hg is a code owner automatically assigned from hashgraph/platform-ci

Assignees

@JeffreyDallas JeffreyDallas

Labels
PR: Ready to Merge A pull request that is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update solo to support pathPrefix of mirror node importer
2 participants
@JeffreyDallas @jeromy-cannon