fix: Refactor task and handler classes #1205

Ivo-Yankov · 2025-01-24T11:33:35Z

Description

This pull request changes the following:

TBD

Related Issues

Closes Refactor task and handler classes #1195

Signed-off-by: Ivo Yankov <[email protected]>

# Conflicts: # src/commands/cluster/handlers.ts # src/commands/cluster/tasks.ts

Signed-off-by: Ivo Yankov <[email protected]>

github-actions · 2025-01-24T12:38:28Z

Unit Test Results - Linux

1 files ±0 59 suites ±0 3s ⏱️ -1s
233 tests ±0 233 ✅ ±0 0 💤 ±0 0 ❌ ±0
238 runs ±0 238 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 39a3a90. ± Comparison against base commit 4ab4dd5.

♻️ This comment has been updated with latest results.

github-actions · 2025-01-24T12:39:18Z

Unit Test Results - Windows

1 files ±0 59 suites ±0 14s ⏱️ -3s
233 tests ±0 233 ✅ ±0 0 💤 ±0 0 ❌ ±0
238 runs ±0 238 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 39a3a90. ± Comparison against base commit 4ab4dd5.

♻️ This comment has been updated with latest results.

Signed-off-by: Ivo Yankov <[email protected]>

# Conflicts: # src/commands/deployment.ts # src/core/config/remote/listr_config_tasks.ts

Signed-off-by: Ivo Yankov <[email protected]>

github-actions · 2025-01-27T13:06:20Z

E2E Test Report

17 files 126 suites 1h 30m 40s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
269 runs 269 ✅ 0 💤 0 ❌

Results for commit 39a3a90.

♻️ This comment has been updated with latest results.

codacy-production · 2025-01-27T13:07:04Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `4ab4dd5`¹	✅ 91.51%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`4ab4dd5`)	Report Missing	Report Missing	Report Missing
Head commit (`39a3a90`)	21857	18306	83.75%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1205)	530	485	91.51%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov · 2025-01-27T13:08:44Z

Codecov Report

Attention: Patch coverage is 91.50943% with 45 lines in your changes missing coverage. Please review.

Project coverage is 82.93%. Comparing base (d60247a) to head (39a3a90).
Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
src/core/command_handler.ts	74.76%	27 Missing ⚠️
src/commands/cluster/handlers.ts	87.87%	4 Missing ⚠️
src/commands/cluster/tasks.ts	95.65%	4 Missing ⚠️
src/commands/node/handlers.ts	94.91%	3 Missing ⚠️
src/commands/base.ts	66.66%	2 Missing ⚠️
src/commands/explorer.ts	71.42%	2 Missing ⚠️
src/commands/mirror_node.ts	75.00%	1 Missing ⚠️
src/commands/network.ts	90.00%	1 Missing ⚠️
src/commands/relay.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
+ Coverage   82.89%   82.93%   +0.03%     
==========================================
  Files          78       80       +2     
  Lines       21763    21857      +94     
  Branches     1824     1996     +172     
==========================================
+ Hits        18041    18127      +86     
+ Misses       3584     3560      -24     
- Partials      138      170      +32

Files with missing lines	Coverage Δ
src/commands/cluster/configs.ts	`84.67% <100.00%> (+0.11%)`	⬆️
src/commands/cluster/index.ts	`38.53% <100.00%> (-2.21%)`	⬇️
src/commands/node/configs.ts	`92.55% <100.00%> (+0.05%)`	⬆️
src/commands/node/index.ts	`17.09% <100.00%> (-5.55%)`	⬇️
src/commands/node/tasks.ts	`92.77% <100.00%> (+0.34%)`	⬆️
src/core/config/remote/listr_config_tasks.ts	`67.32% <100.00%> (+0.30%)`	⬆️
src/core/config_builder.ts	`100.00% <100.00%> (ø)`
src/core/container_init.ts	`95.00% <100.00%> (+0.33%)`	⬆️
src/core/helpers.ts	`83.09% <100.00%> (+1.22%)`	⬆️
src/commands/mirror_node.ts	`75.61% <75.00%> (ø)`
... and 8 more

... and 8 files with indirect coverage changes

jeromy-cannon · 2025-01-27T16:03:06Z

src/commands/base.ts

@@ -71,6 +67,7 @@ export abstract class BaseCommand extends ShellRunner {
    this.remoteConfigManager = opts.remoteConfigManager;
  }

+  // TODO remove


jeromy-cannon · 2025-01-27T18:04:39Z

src/commands/cluster/index.ts

@@ -32,7 +32,8 @@ export class ClusterCommand extends BaseCommand {
  constructor(opts: Opts) {
    super(opts);

-    this.handlers = new ClusterCommandHandlers(this, new ClusterCommandTasks(this, this.k8), this.remoteConfigManager);
+    // TODO properly inject


jeromy-cannon · 2025-01-27T18:08:12Z

src/commands/node/index.ts

-      remoteConfigManager: opts.remoteConfigManager,
-    });
+
+    // TODO properly inject


jeromy-cannon · 2025-01-27T18:10:52Z

src/core/command_handler.ts

+    this.configManager = patchInject(configManager, ConfigManager, this.constructor.name);
+  }
+
+  commandActionBuilder(actionTasks: any, options: any, errorString: string, lease: Lease | null) {


add scope modifier public to method, add return type

jeromy-cannon · 2025-01-27T18:11:09Z

src/core/command_handler.ts

+   * Setup home directories
+   * @param dirs a list of directories that need to be created in sequence
+   */
+  setupHomeDirectory(


add scope modifier public to method, add return type

jeromy-cannon · 2025-01-27T18:11:19Z

src/core/command_handler.ts

+    return dirs;
+  }
+
+  setupHomeDirectoryTask() {


add scope modifier public to method, add return type

jeromy-cannon · 2025-01-27T18:11:25Z

src/core/command_handler.ts

+  }
+
+  // Config related methods:
+  getConfig(configName: string, flags: CommandFlag[], extraProperties: string[] = []): object {


add scope modifier public to method

jeromy-cannon · 2025-01-27T18:11:57Z

src/core/command_handler.ts

+    return getConfig(this.configManager, this._configMaps, configName, flags, extraProperties);
+  }
+
+  getUnusedConfigs(configName: string): string[] {


add scope modifier public to method

jeromy-cannon · 2025-01-27T18:14:01Z

test/unit/commands/cluster.test.ts

@@ -228,16 +241,26 @@ describe('ClusterCommand unit tests', () => {
        certificateManager: sandbox.createStubInstance(CertificateManager),
        remoteConfigManager: remoteConfigManagerStub,
      } as Opts;
+
+      // stubDependencies([Object.values(options)]);


delete commented out code

jeromy-cannon · 2025-01-27T18:14:55Z

test/unit/commands/cluster.test.ts

    };

+    function stubDependencies(deps: any[]) {


is this still being used if it is commented out on line 245?

Ivo-Yankov added 4 commits January 23, 2025 12:48

wip: refactor classes

a6ee2da

Signed-off-by: Ivo Yankov <[email protected]>

Merge branch 'main' into 01195-refactor-task-and-handler-classes

6626cd2

# Conflicts: # src/commands/cluster/handlers.ts # src/commands/cluster/tasks.ts

fix: refactor cluster classes

63b214c

Signed-off-by: Ivo Yankov <[email protected]>

fix: refactor node classes

d06dd40

Signed-off-by: Ivo Yankov <[email protected]>

Ivo-Yankov self-assigned this Jan 24, 2025

Ivo-Yankov added 2 commits January 24, 2025 14:17

chore: format

9dfe512

Signed-off-by: Ivo Yankov <[email protected]>

fix: circular dependencies

9d0d72d

Signed-off-by: Ivo Yankov <[email protected]>

Ivo-Yankov added 4 commits January 27, 2025 11:51

fix: unit tests

7924da1

Signed-off-by: Ivo Yankov <[email protected]>

Merge branch 'main' into 01195-refactor-task-and-handler-classes

c8cb8ab

# Conflicts: # src/commands/deployment.ts # src/core/config/remote/listr_config_tasks.ts

fix: formatting

60fd0b4

Signed-off-by: Ivo Yankov <[email protected]>

fix: failing e2e test

39a3a90

Signed-off-by: Ivo Yankov <[email protected]>

Ivo-Yankov marked this pull request as ready for review January 27, 2025 13:38

Ivo-Yankov requested review from leninmehedy and a team as code owners January 27, 2025 13:38

Ivo-Yankov added the PR: Needs Approval A pull request that needs reviews and approvals. label Jan 27, 2025

jeromy-cannon reviewed Jan 27, 2025

View reviewed changes

src/commands/node/index.ts

remoteConfigManager: opts.remoteConfigManager,

});

// TODO properly inject

Copy link

Contributor

jeromy-cannon Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

jeromy-cannon reviewed Jan 27, 2025

View reviewed changes

jeromy-cannon added PR: Unresolved Comments A pull request where there are comments and they need to be resolved. and removed PR: Needs Approval A pull request that needs reviews and approvals. labels Jan 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Refactor task and handler classes #1205

fix: Refactor task and handler classes #1205

Ivo-Yankov commented Jan 24, 2025 •

edited

Loading

github-actions bot commented Jan 24, 2025 •

edited

Loading

github-actions bot commented Jan 24, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

codacy-production bot commented Jan 27, 2025

codecov bot commented Jan 27, 2025 •

edited

Loading

jeromy-cannon Jan 27, 2025

jeromy-cannon Jan 27, 2025

jeromy-cannon Jan 27, 2025

jeromy-cannon Jan 27, 2025

jeromy-cannon Jan 27, 2025

jeromy-cannon Jan 27, 2025

jeromy-cannon Jan 27, 2025 •

edited

Loading

jeromy-cannon Jan 27, 2025

jeromy-cannon Jan 27, 2025

jeromy-cannon Jan 27, 2025

fix: Refactor task and handler classes #1205

Are you sure you want to change the base?

fix: Refactor task and handler classes #1205

Conversation

Ivo-Yankov commented Jan 24, 2025 • edited Loading

Description

Related Issues

github-actions bot commented Jan 24, 2025 • edited Loading

Unit Test Results - Linux

github-actions bot commented Jan 24, 2025 • edited Loading

Unit Test Results - Windows

github-actions bot commented Jan 27, 2025 • edited Loading

E2E Test Report

codacy-production bot commented Jan 27, 2025

Coverage summary from Codacy

Footnotes

codecov bot commented Jan 27, 2025 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeromy-cannon Jan 27, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ivo-Yankov commented Jan 24, 2025 •

edited

Loading

github-actions bot commented Jan 24, 2025 •

edited

Loading

github-actions bot commented Jan 24, 2025 •

edited

Loading

github-actions bot commented Jan 27, 2025 •

edited

Loading

codecov bot commented Jan 27, 2025 •

edited

Loading

jeromy-cannon Jan 27, 2025 •

edited

Loading