Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use common Hiero Gradle config #302

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

build: use common Hiero Gradle config #302

wants to merge 13 commits into from

Conversation

jjohannes
Copy link
Collaborator

@jjohannes jjohannes commented Oct 9, 2024 •
edited
Loading

Description:

Before this can be integrated:

Related issue(s):

hashgraph/hedera-services#14255

@jjohannes jjohannes mentioned this pull request Oct 9, 2024
Closed
@jjohannes jjohannes changed the title build: use plugins from 'hedera-gradle-conventions' build: use common Hedera Gradle config Oct 9, 2024
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 23f5995 to 8be0e9c Compare October 9, 2024 10:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

JUnit Test Report

   67 files  ±0     67 suites  ±0   2m 0s ⏱️ -41s
1 265 tests ±0  1 262 ✅ ±0   3 💤 ±0  0 ❌ ±0 
7 120 runs  ±0  7 101 ✅ ±0  19 💤 ±0  0 ❌ ±0 

Results for commit 6bf0c51. ± Comparison against base commit 4088c86.

♻️ This comment has been updated with latest results.

@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 4 times, most recently from 0421a05 to 287af73 Compare October 11, 2024 07:05
@jjohannes jjohannes changed the title build: use common Hedera Gradle config build: use common Hiero Gradle config Nov 4, 2024
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from 287af73 to 66309f0 Compare December 19, 2024 09:17
@jjohannes jjohannes mentioned this pull request Dec 19, 2024
Closed
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch 2 times, most recently from 00bfb81 to ffeefe6 Compare December 19, 2024 09:41
@jjohannes jjohannes self-assigned this Dec 19, 2024
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from ffeefe6 to e6fd5d9 Compare January 9, 2025 09:36
@jjohannes jjohannes force-pushed the 14255-reusable-gradle-config branch from e6fd5d9 to 58f0a22 Compare January 9, 2025 09:40
@jjohannes jjohannes marked this pull request as ready for review January 9, 2025 12:46
@jjohannes jjohannes requested a review from a team as a code owner January 9, 2025 12:46
@jjohannes jjohannes requested review from a team as code owners January 9, 2025 12:46
anthony-swirldslabs
anthony-swirldslabs previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@anthony-swirldslabs anthony-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm not an expert in Gradle or GitHub scripts, the modifications look reasonable to me. But it would be great to have an expert review those changes as well.

Java code changes look great. Approved.

pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/PbjCompiler.java Outdated Show resolved Hide resolved
mishomihov00
mishomihov00 previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to:
.github/dependabot.yml
.github/workflows/flow-deploy-release-artifact.yaml
.github/workflows/zxc-compile-pbj-code.yaml

@jjohannes
ci: fix NEXUS_* env variable names
6bf0c51 
Signed-off-by: Jendrik Johannes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-swirldslabs anthony-swirldslabs anthony-swirldslabs approved these changes

@mishomihov00 mishomihov00 mishomihov00 left review comments

@dalvizu dalvizu Awaiting requested review from dalvizu dalvizu is a code owner automatically assigned from hashgraph/devops-ci

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner automatically assigned from hashgraph/release-engineering-managers

@andrewb1269hg andrewb1269hg Awaiting requested review from andrewb1269hg

Assignees

@jjohannes jjohannes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjohannes @anthony-swirldslabs @mishomihov00