Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend support for alias form of AccountIDs to all relevant transactions and queries #2779

Closed
wants to merge 62 commits into from
Closed

Extend support for alias form of AccountIDs to all relevant transactions and queries #2779

wants to merge 62 commits into from

Conversation

anighanta
Copy link
Contributor

@anighanta anighanta commented Jan 20, 2022 •
edited by Neeharika-Sompalli
Loading

Closes #2691

  • Adds support for alias form of AccountIDs for all Transactions and Queries.
  • Added AliasLookup to provide the resolved id by looking in AliasManager and corresponding response code if the ID doesn't exist in aliasManager
  • If the account to look up is not of alias form , the ID is taken without lookup
  • Updating existing accounts' alias is in this PR

Neeharika-Sompalli and others added 30 commits January 3, 2022 16:58
initial commit
71c6519
initial commit
5dacffa
@anighanta
added support to use alias account for token associate,dissociate,fre…
619d949 
…eze,unfreeze,revoke,grant,wipe,create transactions

Signed-off-by: anighanta <[email protected]>
@anighanta
add unit tests for TokenWipeTransitionLogic
bfbba79 
Signed-off-by: anighanta <[email protected]>
@anighanta
add unit tests for token creation changes to support alias in treasur…
dd7eaa0 
…y and autorenewAccount

Signed-off-by: anighanta <[email protected]>
work in progress for crypto changes
280b2a7
Merge remote-tracking branch 'origin/02691-M-ExtendAliasSupport' into…
2996a1c 
… 02691-M-ExtendAliasSupport
fix failing tests
aff407e
fix failing tests
c9a83fb
add tests
a4299b8
@anighanta
add eet specs and add support for alias accounts in token ops
8958734 
Signed-off-by: anighanta <[email protected]>
misc changes for clean up
f1563fe
@anighanta
add support to TokenUpdate op for alias accounts
e04476a 
Signed-off-by: anighanta <[email protected]>
token and record specs pass
6923e25
Merge remote-tracking branch 'origin/02691-M-ExtendAliasSupport' into…
292ce92 
… 02691-M-ExtendAliasSupport
Merge branch 'master' into 02691-M-ExtendAliasSupport
0b369d7
@anighanta
add EETs for tokenCreate and tokenUpdate ops with alias accounts
63b392e 
Signed-off-by: anighanta <[email protected]>
TopicCreate and TopicUpdate with unit tests
43cb764
Merge remote-tracking branch 'origin/02691-M-ExtendAliasSupport' into…
056789a 
… 02691-M-ExtendAliasSupport
@anighanta
refactor hapiTOkenCreate and tokenUdpate alias account management logic
c40f942 
Signed-off-by: anighanta <[email protected]>
TopicCreate and TopicUpdate EETs
4a31996
@anighanta
use alias form of account when sending txns
40d5f56 
Signed-off-by: anighanta <[email protected]>
@anighanta
Merge branch '02691-M-ExtendAliasSupport' of https://github.com/hashg…
2b4ed05 
…raph/hedera-services into 02691-M-ExtendAliasSupport
@anighanta
udpated hedera ledger to use accout lookup from aliasManager
3838ea2 
Signed-off-by: anighanta <[email protected]>
clean up crypto and fix failing unit tests
c18e719
clean up queries
0e098eb
clean up queries
d9597b9
@anighanta
crude way to fetch accountNum form of alias for transaction payer
121b25b 
Signed-off-by: anighanta <[email protected]>
@anighanta
EET : fix crypto transfer with hbar only transfers signing
487a286 
Signed-off-by: anighanta <[email protected]>
@anighanta
Merge branch 'master' into 02691-M-ExtendAliasSupport
12f80ce
@Neeharika-Sompalli Neeharika-Sompalli marked this pull request as ready for review January 24, 2022 16:06
anighanta and others added 11 commits January 24, 2022 12:31
@anighanta
use INVALID_SCHEDULE_PAYER_ID for invalid designated payers of a sche…
ee0dc2a 
…dule when creating

Signed-off-by: anighanta <[email protected]>
@anighanta
use PAYER_ACCUNT_NOT_FOUND instead of INVALID_PAYER_ACCOUNT_ID when p…
bb5f911 
…ayer is invalid

Signed-off-by: anighanta <[email protected]>
@anighanta
minor cleanup
8ba0b86 
Signed-off-by: anighanta <[email protected]>
@anighanta
fix contract ops alias usage
2b7443f 
Signed-off-by: anighanta <[email protected]>
@anighanta
fix contract ops alias usage
87022da 
Signed-off-by: anighanta <[email protected]>
Merge branch 'master' into 02691-M-ExtendAliasSupport
d931698
@anighanta
validate detached status of the account to be deleted
b2174fe 
Signed-off-by: anighanta <[email protected]>
@anighanta
Merge branch '02691-M-ExtendAliasSupport' of https://github.com/hashg…
b9ab66f 
…raph/hedera-services into 02691-M-ExtendAliasSupport
@anighanta
address code smells
558a674 
Signed-off-by: anighanta <[email protected]>
@anighanta
add positive scenario for tokenWipe using alias
a6cd84f 
Signed-off-by: anighanta <[email protected]>
@Neeharika-Sompalli
Allow existing accounts to update their alias (#2788)
fa7ea01 
* add sig requirement for alias

* unit tests

* unit tests

* eet tests

* test coverage

* fix sonar smells

* fix sonar smells

* remove duplicated unit test as per review comments

* Merge branch 'master' into 02691-M-ExtendAliasSupport
@SimiHunjan SimiHunjan added this to the 0.24.0 milestone Feb 8, 2022
@SimiHunjan
Copy link
Contributor

moved to 0.25 release

@SimiHunjan SimiHunjan modified the milestones: 0.24.0, 0.25.0 Feb 23, 2022
@SimiHunjan SimiHunjan modified the milestones: 0.25.0, 0.26.0 Mar 22, 2022
@SimiHunjan SimiHunjan modified the milestones: 0.26.0, 0.25.0, 0.27.0 Apr 20, 2022
@SimiHunjan SimiHunjan removed this from the 0.27.0 milestone May 17, 2022
@tinker-michaelj
Copy link
Collaborator

Unclear if this work would align with the upcoming alias restructure.

@nathanklick nathanklick deleted the 02691-M-ExtendAliasSupport branch August 18, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neeharika-Sompalli Neeharika-Sompalli Awaiting requested review from Neeharika-Sompalli

@tinker-michaelj tinker-michaelj Awaiting requested review from tinker-michaelj

@qnswirlds qnswirlds Awaiting requested review from qnswirlds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support aliases in all transactions and queries
4 participants
@anighanta @SimiHunjan @tinker-michaelj @Neeharika-Sompalli