Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix dry-run-enabled parameter passing #16497

Conversation

mishomihov00
Copy link
Contributor

@mishomihov00 mishomihov00 commented Nov 8, 2024

Description:

Fix dry-run-enabled parameter passing

Related issue(s):

Fixes #11046

Notes for reviewer:

Test workflow run: https://github.com/hashgraph/hedera-services/actions/runs/11739466577/job/32704033446
The error at the end seems to be desired as the pipeline should not be trigger with the dry-run-enabled parameter being true

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mishomihov00 mishomihov00 added the github_actions Pull requests that update GitHub Actions code label Nov 8, 2024
@mishomihov00 mishomihov00 added this to the v0.57 milestone Nov 8, 2024
@mishomihov00 mishomihov00 self-assigned this Nov 8, 2024
@mishomihov00 mishomihov00 requested review from a team as code owners November 8, 2024 09:21
@mishomihov00 mishomihov00 linked an issue Nov 8, 2024 that may be closed by this pull request
Signed-off-by: Mihail Mihov <[email protected]>
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.36%. Comparing base (a1fc460) to head (596b69f).
Report is 11 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #16497   +/-   ##
==========================================
  Coverage      63.36%   63.36%           
  Complexity     20108    20108           
==========================================
  Files           2527     2527           
  Lines          93722    93722           
  Branches        9811     9811           
==========================================
  Hits           59391    59391           
  Misses         30732    30732           
  Partials        3599     3599           

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a1fc460) 96541 62852 65.10%
Head commit (596b69f) 96541 (+0) 62852 (+0) 65.10% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#16497) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mishomihov00 mishomihov00 merged commit ab3635d into develop Nov 11, 2024
57 of 58 checks passed
@mishomihov00 mishomihov00 deleted the 11046-fix-dry-run-enabled-not-working-correctly-on-previewnet-pipeline branch November 11, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: dry-run-enabled not working correctly on previewnet pipeline
2 participants