-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix dry-run-enabled parameter passing #16497
ci: Fix dry-run-enabled parameter passing #16497
Conversation
Signed-off-by: Mihail Mihov <[email protected]>
Signed-off-by: Mihail Mihov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16497 +/- ##
==========================================
Coverage 63.36% 63.36%
Complexity 20108 20108
==========================================
Files 2527 2527
Lines 93722 93722
Branches 9811 9811
==========================================
Hits 59391 59391
Misses 30732 30732
Partials 3599 3599 |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Description:
Fix dry-run-enabled parameter passing
Related issue(s):
Fixes #11046
Notes for reviewer:
Test workflow run: https://github.com/hashgraph/hedera-services/actions/runs/11739466577/job/32704033446
The error at the end seems to be desired as the pipeline should not be trigger with the
dry-run-enabled
parameter beingtrue
Checklist