-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support restarting from RECORDS
-> BOTH
#15904
Conversation
Signed-off-by: Michael Tinker <[email protected]>
Signed-off-by: Michael Tinker <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15904 +/- ##
=============================================
- Coverage 58.14% 58.14% -0.01%
- Complexity 21633 21635 +2
=============================================
Files 2786 2788 +2
Lines 109604 109665 +61
Branches 11215 11224 +9
=============================================
+ Hits 63733 63766 +33
- Misses 41995 42019 +24
- Partials 3876 3880 +4
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Michael Tinker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Although I can't load/see the new Codacy issues.
Please review the Codacy findings before merging. |
Codacy hasn't yet been tuned to a useful rule set. It frequently complains about issues that aren't issues. I'm not sure why it's running at all at this point. |
Reviewed and these findings are not actionable given our repo conventions, thx @andrewb1269hg ! |
Description:
BlockStreamInfo
migration logic needs to run in aSchema
of the latest version #15899