-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement gRPC publishBlockStream streaming of blocks #15541
Conversation
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15541 +/- ##
=============================================
- Coverage 58.35% 58.33% -0.02%
- Complexity 19975 19981 +6
=============================================
Files 2735 2736 +1
Lines 100339 100437 +98
Branches 10365 10375 +10
=============================================
+ Hits 58548 58588 +40
- Misses 38164 38217 +53
- Partials 3627 3632 +5
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review applies to:
gradle/plugins/src/main/kotlin/com.hedera.gradle.jpms-modules.gradle.kts
hedera-dependency-versions/build.gradle.kts
hedera-node/hedera-app/build.gradle.kts
hedera-node/hedera-app/src/main/java/module-info.java
LGTM
gradle/plugins/src/main/kotlin/com.hedera.gradle.jpms-modules.gradle.kts
Show resolved
Hide resolved
Signed-off-by: Petar Tonev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review applies to:
- gradle/plugins/src/main/kotlin/com.hedera.gradle.jpms-modules.gradle.kts
- hedera-dependency-versions/build.gradle.kts
- hedera-node/hedera-app/build.gradle.kts
- hedera-node/hedera-app/src/main/java/module-info.java
LGTM
Signed-off-by: Petar Tonev <[email protected]>
# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/blocks/BlockItemWriter.java # hedera-node/hedera-app/src/main/java/com/hedera/node/app/blocks/impl/BlockStreamManagerImpl.java # hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/BlockStreamConfig.java
Signed-off-by: Petar Tonev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review applies to:
- gradle/plugins/src/main/kotlin/com.hedera.gradle.jpms-modules.gradle.kts
- hedera-dependency-versions/build.gradle.kts
- hedera-node/hedera-app/build.gradle.kts
- hedera-node/hedera-app/src/main/java/module-info.java
LGTM
Node: HAPI Test (Restart) Results5 tests 1 ✅ 2m 36s ⏱️ For more details on these parsing errors and failures, see this check. Results for commit 15d0d42. ♻️ This comment has been updated with latest results. |
hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/BlockStreamConfig.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Petar Tonev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Signed-off-by: Petar Tonev <[email protected]>
Description:
Related issue(s):
Fixes #15526
Notes for reviewer:
Checklist