Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement gRPC publishBlockStream streaming of blocks #15541

Merged
merged 63 commits into from
Oct 31, 2024

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Sep 18, 2024

Description:

Related issue(s):

Fixes #15526

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Petar Tonev <[email protected]>
@petreze petreze added the Block Streams All Issues related to block streams label Sep 18, 2024
@petreze petreze added this to the v0.55 milestone Sep 18, 2024
@petreze petreze self-assigned this Sep 18, 2024
@petreze petreze linked an issue Sep 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 35.00000% with 65 lines in your changes missing coverage. Please review.

Project coverage is 58.33%. Comparing base (593a623) to head (15d0d42).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
...dera/node/app/blocks/impl/GrpcBlockItemWriter.java 33.68% 59 Missing and 4 partials ⚠️
.../com/hedera/node/app/blocks/BlockStreamModule.java 0.00% 1 Missing ⚠️
...a/node/app/blocks/impl/BlockStreamManagerImpl.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #15541      +/-   ##
=============================================
- Coverage      58.35%   58.33%   -0.02%     
- Complexity     19975    19981       +6     
=============================================
  Files           2735     2736       +1     
  Lines         100339   100437      +98     
  Branches       10365    10375      +10     
=============================================
+ Hits           58548    58588      +40     
- Misses         38164    38217      +53     
- Partials        3627     3632       +5     
Files with missing lines Coverage Δ
...va/com/hedera/node/app/blocks/BlockItemWriter.java 50.00% <ø> (+50.00%) ⬆️
...com/hedera/node/config/data/BlockStreamConfig.java 100.00% <ø> (ø)
.../com/hedera/node/app/blocks/BlockStreamModule.java 0.00% <0.00%> (ø)
...a/node/app/blocks/impl/BlockStreamManagerImpl.java 95.30% <75.00%> (-0.32%) ⬇️
...dera/node/app/blocks/impl/GrpcBlockItemWriter.java 33.68% <33.68%> (ø)

... and 5 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Sep 18, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) 40.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (593a623) 100156 62038 61.94%
Head commit (15d0d42) 100254 (+98) 62083 (+45) 61.93% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15541) 100 40 40.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@petreze petreze marked this pull request as ready for review September 19, 2024 08:13
@petreze petreze requested a review from a team September 19, 2024 08:13
@petreze petreze requested review from a team as code owners September 19, 2024 08:13
rbarkerSL
rbarkerSL previously approved these changes Oct 15, 2024
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to:

  • gradle/plugins/src/main/kotlin/com.hedera.gradle.jpms-modules.gradle.kts
  • hedera-dependency-versions/build.gradle.kts
  • hedera-node/hedera-app/build.gradle.kts
  • hedera-node/hedera-app/src/main/java/module-info.java

LGTM

rbarkerSL
rbarkerSL previously approved these changes Oct 16, 2024
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to:

  • gradle/plugins/src/main/kotlin/com.hedera.gradle.jpms-modules.gradle.kts
  • hedera-dependency-versions/build.gradle.kts
  • hedera-node/hedera-app/build.gradle.kts
  • hedera-node/hedera-app/src/main/java/module-info.java

LGTM

Signed-off-by: Petar Tonev <[email protected]>
# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/blocks/BlockItemWriter.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/blocks/impl/BlockStreamManagerImpl.java
#	hedera-node/hedera-config/src/main/java/com/hedera/node/config/data/BlockStreamConfig.java
Signed-off-by: Petar Tonev <[email protected]>
rbarkerSL
rbarkerSL previously approved these changes Oct 18, 2024
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to:

  • gradle/plugins/src/main/kotlin/com.hedera.gradle.jpms-modules.gradle.kts
  • hedera-dependency-versions/build.gradle.kts
  • hedera-node/hedera-app/build.gradle.kts
  • hedera-node/hedera-app/src/main/java/module-info.java

LGTM

Copy link

github-actions bot commented Oct 21, 2024

Node: HAPI Test (Restart) Results

5 tests   1 ✅  2m 36s ⏱️
6 suites  0 💤
9 files    4 ❌
3 errors

For more details on these parsing errors and failures, see this check.

Results for commit 15d0d42.

♻️ This comment has been updated with latest results.

@petreze petreze dismissed stale reviews from mhess-swl and rbarkerSL via 95ac65e October 23, 2024 13:05
Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@petreze petreze merged commit 196d78a into develop Oct 31, 2024
48 of 50 checks passed
@petreze petreze deleted the 15526-blockstreams-grpc branch October 31, 2024 14:07
Evdokia-Georgieva pushed a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Streams All Issues related to block streams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a gRPC client for publishBlockStream rpc (design for some handshaking)
8 participants