Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix to deterministic iteration order #12401

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

Neeharika-Sompalli
Copy link
Member

No description provided.

Signed-off-by: Neeharika-Sompalli <[email protected]>
@Neeharika-Sompalli Neeharika-Sompalli requested a review from a team March 27, 2024 14:57
@Neeharika-Sompalli Neeharika-Sompalli requested a review from a team as a code owner March 27, 2024 14:57
@Neeharika-Sompalli Neeharika-Sompalli self-assigned this Mar 27, 2024
Signed-off-by: Neeharika-Sompalli <[email protected]>
Copy link

Node: HAPI Test (Restart) Results

2 tests   2 ✔️  6m 8s ⏱️
2 suites  0 💤
2 files    0

Results for commit 331d659.

Copy link

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✔️  6m 46s ⏱️
2 suites  0 💤
2 files    0

Results for commit 331d659.

Copy link

Node: HAPI Test (Token) Results

202 tests   202 ✔️  21m 36s ⏱️
  16 suites      0 💤
  16 files        0

Results for commit 331d659.

Copy link

Node: HAPI Test (Crypto) Results

214 tests   214 ✔️  26m 39s ⏱️
  23 suites      0 💤
  23 files        0

Results for commit 331d659.

Copy link

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✔️  54m 25s ⏱️
  3 suites    0 💤
  3 files      0

Results for commit 331d659.

Copy link

Node: HAPI Test (Smart Contract) Results

494 tests   491 ✔️  1h 7m 30s ⏱️
  55 suites      3 💤
  55 files        0

Results for commit 331d659.

Copy link

Node: Unit Test Results

    2 264 files  ±0      2 264 suites  ±0   3h 27m 22s ⏱️ + 18m 16s
112 179 tests ±0  112 130 ✔️ ±0  49 💤 ±0  0 ±0 
120 640 runs  ±0  120 591 ✔️ ±0  49 💤 ±0  0 ±0 

Results for commit 331d659. ± Comparison against base commit 6e57fd8.

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 61.07%. Comparing base (6e57fd8) to head (331d659).
Report is 2 commits behind head on release/0.48.

Files Patch % Lines
...ken/impl/schemas/InitialModServiceTokenSchema.java 0.00% 2 Missing ⚠️
...impl/schemas/InitialModServiceConsensusSchema.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release/0.48   #12401   +/-   ##
===============================================
  Coverage           61.06%   61.07%           
  Complexity          30791    30791           
===============================================
  Files                3442     3442           
  Lines              140918   140918           
  Branches            14704    14704           
===============================================
+ Hits                86056    86060    +4     
+ Misses              51097    51096    -1     
+ Partials             3765     3762    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Neeharika-Sompalli Neeharika-Sompalli changed the title Fix to deterministic iteration order fix: Fix to deterministic iteration order Mar 28, 2024
Copy link

Node: HAPI Test (Misc) Results

432 tests   421 ✔️  39m 35s ⏱️
  75 suites    10 💤
  75 files        1

For more details on these failures, see this check.

Results for commit 331d659.

Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Neeharika-Sompalli !

@Neeharika-Sompalli Neeharika-Sompalli merged commit e9b53b2 into release/0.48 Mar 28, 2024
44 of 51 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the make-deterministic-iteration branch March 28, 2024 14:21
Neeharika-Sompalli added a commit that referenced this pull request Mar 28, 2024
Neeharika-Sompalli added a commit that referenced this pull request Mar 28, 2024
netopyr added a commit that referenced this pull request Mar 28, 2024
* release/0.48:
  chore: Migration fixes from state dumpers (#12392)
  fix: Clean up leaked virtual maps after migration (#12411)
  fix: Fix signing requirements for updating metadata on Token (#12409)
  feat: Utilization metrics (#12402)
  fix: Fix to deterministic iteration order (#12401)
  fix: (mono) reclaim entity id after failed auto-create; avoid `FAIL_INVALID` on invalid token id (#12322)
  chore: rely on protobuf release 48 branch instead of main (#12376)
  fix: fixed diff test issue 12355. (#12375)
  fix: ContractCallLocal INSUFFICIENT_GAS ERROR (#12362)
  fix: disable birth rounds (#12351)

# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/Hedera.java
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/state/merkle/MerkleHederaState.java
imalygin pushed a commit that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants