Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: turn off the allowCallstoNonContractAccounts feature flag #11208

Closed

Conversation

lukelee-sl
Copy link
Member

Description:
Turn off the allowCallstoNonContractAccounts feature flag in all environments

@lukelee-sl lukelee-sl self-assigned this Jan 26, 2024
@lukelee-sl lukelee-sl requested a review from a team January 26, 2024 19:51
@lukelee-sl lukelee-sl requested a review from a team as a code owner January 26, 2024 19:51
@Nana-EC Nana-EC added this to the v0.46 milestone Jan 26, 2024
Copy link

Node: HAPI Test (Token) Results

189 tests  ±0   189 ✔️ ±0   17m 20s ⏱️ - 1m 28s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit 4613522. ± Comparison against base commit a723e9c.

Copy link

Node: HAPI Test (Crypto) Results

211 tests  ±0   208 ✔️ ±0   18m 13s ⏱️ + 1m 12s
  22 suites ±0       3 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit 4613522. ± Comparison against base commit a723e9c.

Copy link

Node: Unit Test Results

    2 294 files  ±0      2 294 suites  ±0   52m 8s ⏱️ + 5m 23s
118 681 tests ±0  118 644 ✔️  - 2  35 💤 ±0  2 +2 
127 098 runs  ±0  127 061 ✔️  - 2  35 💤 ±0  2 +2 

For more details on these failures, see this check.

Results for commit 4613522. ± Comparison against base commit a723e9c.

Copy link

Node: HAPI Test (Misc) Results

383 tests  ±0   323 ✔️ ±0   24m 56s ⏱️ -19s
  72 suites ±0     60 💤 ±0 
  72 files   ±0       0 ±0 

Results for commit 4613522. ± Comparison against base commit a723e9c.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a723e9c) 62.79% compared to head (4613522) 62.79%.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/0.46   #11208   +/-   ##
===============================================
  Coverage           62.79%   62.79%           
- Complexity          31011    31013    +2     
===============================================
  Files                3384     3384           
  Lines              136931   136931           
  Branches            14310    14310           
===============================================
+ Hits                85983    85985    +2     
+ Misses              47504    47503    -1     
+ Partials             3444     3443    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @lukelee-sl !

Copy link

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   24m 10s ⏱️ + 24m 10s
311 tests +310  310 ✔️ +310  0 💤 ±0  1 ±0 
333 runs  +332  332 ✔️ +332  0 💤 ±0  1 ±0 

For more details on these failures, see this check.

Results for commit 4613522. ± Comparison against base commit a723e9c.

Copy link

Node: HAPI Test (Time Consuming) Results

20 tests  ±0   17 ✔️ ±0   45m 3s ⏱️ +34s
  2 suites ±0     3 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit 4613522. ± Comparison against base commit a723e9c.

Copy link

Node: HAPI Test (Smart Contract) Results

444 tests  ±0   419 ✔️  - 16   54m 46s ⏱️ -1s
  52 suites ±0       9 💤 ±  0 
  52 files   ±0     16 +16 

For more details on these failures, see this check.

Results for commit 4613522. ± Comparison against base commit a723e9c.

Copy link

Node: Integration Test Results

    5 files  ±0      5 suites  ±0   1h 5m 44s ⏱️ -3s
312 tests ±0  309 ✔️  - 3  0 💤 ±0  3 +3 
314 runs  ±0  311 ✔️  - 3  0 💤 ±0  3 +3 

For more details on these failures, see this check.

Results for commit 4613522. ± Comparison against base commit a723e9c.

Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking, just in case.

@lukelee-sl lukelee-sl closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants