fix: use concurrent hashmap instead of synchroniztion for recordcache #11112

povolev15 · 2024-01-23T15:44:56Z

This PR fix the ReadableKVStateBase.readCache is not properly synchronized

Related issue(s):

Fixes #10127

github-actions · 2024-01-23T16:22:59Z

Node: HAPI Test (Restart) Results

1 tests 1 ✔️ 5m 55s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 35dad2a.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-23T16:25:51Z

Node: HAPI Test (Node Death Reconnect) Results

1 tests 1 ✔️ 7m 21s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 35dad2a.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-23T16:35:41Z

Node: HAPI Test (Token) Results

189 tests 189 ✔️ 17m 27s ⏱️
  13 suites     0 💤
  13 files     0 ❌

Results for commit 35dad2a.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-23T16:42:16Z

Node: HAPI Test (Crypto) Results

209 tests +209 208 ✔️ +208 21m 37s ⏱️ + 21m 37s
  22 suites +  22     0 💤 ±    0
  22 files +  22     1 ❌ +    1

For more details on these failures, see this check.

Results for commit 654c1fb. ± Comparison against base commit 12c2ff0.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-23T16:43:56Z

Node: E2E Test Results

    1 files     1 suites 24m 29s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs 333 ✔️ 0 💤 0 ❌

Results for commit 35dad2a.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-23T16:47:18Z

Node: Unit Test Results

    2 293 files ±0     2 293 suites ±0 57m 53s ⏱️ - 5m 2s
118 821 tests ±0 118 783 ✔️ ±0 38 💤 ±0 0 ❌ ±0
127 362 runs ±0 127 324 ✔️ ±0 38 💤 ±0 0 ❌ ±0

Results for commit 35dad2a. ± Comparison against base commit 74bbe50.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-23T16:55:17Z

Node: HAPI Test (Misc) Results

429 tests 415 ✔️ 35m 23s ⏱️
  74 suites   14 💤
  74 files     0 ❌

Results for commit 35dad2a.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-23T17:11:28Z

Node: HAPI Test (Time Consuming) Results

20 tests 20 ✔️ 54m 12s ⏱️
  2 suites   0 💤
  2 files   0 ❌

Results for commit 35dad2a.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-23T17:12:50Z

Node: HAPI Test (Smart Contract) Results

446 tests 446 ✔️ 53m 16s ⏱️
  52 suites     0 💤
  52 files     0 ❌

Results for commit 35dad2a.

♻️ This comment has been updated with latest results.

github-actions · 2024-01-23T17:25:07Z

Node: Integration Test Results

    5 files     5 suites 1h 6m 40s ⏱️
319 tests 319 ✔️ 0 💤 0 ❌
331 runs 331 ✔️ 0 💤 0 ❌

Results for commit 35dad2a.

♻️ This comment has been updated with latest results.

hedera-node/hedera-app-spi/src/main/java/com/hedera/node/app/spi/state/ReadableKVStateBase.java

codecov · 2024-01-23T19:02:37Z

Codecov Report

Attention: 206 lines in your changes are missing coverage. Please review.

Comparison is base (d7c6703) 63.25% compared to head (35dad2a) 63.27%.
Report is 7 commits behind head on develop.

Files	Patch %	Lines
...wirlds/platform/crypto/EnhancedKeyStoreLoader.java	69.55%	63 Missing and 25 partials ⚠️
...ice/token/impl/handlers/CryptoTransferHandler.java	0.00%	40 Missing ⚠️
.../hedera/node/app/workflows/handle/CacheWarmer.java	0.00%	26 Missing ⚠️
...java/com/swirlds/platform/crypto/CryptoStatic.java	0.00%	13 Missing ⚠️
...ain/java/com/swirlds/platform/SwirldsPlatform.java	0.00%	11 Missing ⚠️
...-app/src/main/java/com/hedera/node/app/Hedera.java	0.00%	7 Missing ⚠️
...a/node/app/workflows/handle/WarmupContextImpl.java	0.00%	6 Missing ⚠️
...latform/event/creation/rules/BackpressureRule.java	0.00%	2 Missing ⚠️
...ava/com/swirlds/platform/gossip/GossipFactory.java	0.00%	2 Missing ⚠️
...a/com/swirlds/platform/gossip/sync/SyncGossip.java	0.00%	2 Missing ⚠️
... and 9 more

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #11112      +/-   ##
=============================================
+ Coverage      63.25%   63.27%   +0.01%     
- Complexity     31328    31394      +66     
=============================================
  Files           3393     3397       +4     
  Lines         137675   138082     +407     
  Branches       14414    14463      +49     
=============================================
+ Hits           87091    87375     +284     
- Misses         46983    47079      +96     
- Partials        3601     3628      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Lev Povolotsky <[email protected]>

Neeharika-Sompalli

LGTM ! Thanks @povolev15

povolev15 self-assigned this Jan 23, 2024

povolev15 requested review from a team, Neeharika-Sompalli and tinker-michaelj January 23, 2024 15:44

jsync-swirlds previously approved these changes Jan 23, 2024

View reviewed changes

Neeharika-Sompalli reviewed Jan 23, 2024

View reviewed changes

hedera-node/hedera-app-spi/src/main/java/com/hedera/node/app/spi/state/ReadableKVStateBase.java Outdated Show resolved Hide resolved

Neeharika-Sompalli reviewed Jan 23, 2024

View reviewed changes

hedera-node/hedera-app-spi/src/main/java/com/hedera/node/app/spi/state/ReadableKVStateBase.java Outdated Show resolved Hide resolved

povolev15 dismissed jsync-swirlds’s stale review via 654c1fb January 23, 2024 18:11

jsync-swirlds previously approved these changes Jan 23, 2024

View reviewed changes

povolev15 dismissed jsync-swirlds’s stale review via 9d62e50 January 23, 2024 19:05

povolev15 added 4 commits January 23, 2024 14:05

fix: use concurrent hashmap instead of synchroniztion for recordcache

f75c043

Signed-off-by: Lev Povolotsky <[email protected]>

fix: use concurrent hashmap instead of synchroniztion for recordcache

432b6c7

Signed-off-by: Lev Povolotsky <[email protected]>

fix: use concurrent hashmap instead of synchroniztion for recordcache

cc90eda

Signed-off-by: Lev Povolotsky <[email protected]>

fix: use concurrent hashmap instead of synchroniztion for recordcache

35dad2a

Signed-off-by: Lev Povolotsky <[email protected]>

povolev15 force-pushed the 10127-change-readCache-to-be-concurrent branch from 9d62e50 to 35dad2a Compare January 23, 2024 19:06

jsync-swirlds approved these changes Jan 23, 2024

View reviewed changes

Neeharika-Sompalli approved these changes Jan 23, 2024

View reviewed changes

povolev15 merged commit 373e21b into develop Jan 23, 2024
40 of 42 checks passed

povolev15 deleted the 10127-change-readCache-to-be-concurrent branch January 23, 2024 20:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use concurrent hashmap instead of synchroniztion for recordcache #11112

fix: use concurrent hashmap instead of synchroniztion for recordcache #11112

povolev15 commented Jan 23, 2024

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

codecov bot commented Jan 23, 2024 •

edited

Loading

Neeharika-Sompalli left a comment

fix: use concurrent hashmap instead of synchroniztion for recordcache #11112

fix: use concurrent hashmap instead of synchroniztion for recordcache #11112

Conversation

povolev15 commented Jan 23, 2024

github-actions bot commented Jan 23, 2024 • edited Loading

Node: HAPI Test (Restart) Results

github-actions bot commented Jan 23, 2024 • edited Loading

Node: HAPI Test (Node Death Reconnect) Results

github-actions bot commented Jan 23, 2024 • edited Loading

Node: HAPI Test (Token) Results

github-actions bot commented Jan 23, 2024 • edited Loading

Node: HAPI Test (Crypto) Results

github-actions bot commented Jan 23, 2024 • edited Loading

Node: E2E Test Results

github-actions bot commented Jan 23, 2024 • edited Loading

Node: Unit Test Results

github-actions bot commented Jan 23, 2024 • edited Loading

Node: HAPI Test (Misc) Results

github-actions bot commented Jan 23, 2024 • edited Loading

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Jan 23, 2024 • edited Loading

Node: HAPI Test (Smart Contract) Results

github-actions bot commented Jan 23, 2024 • edited Loading

Node: Integration Test Results

codecov bot commented Jan 23, 2024 • edited Loading

Codecov Report

Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

github-actions bot commented Jan 23, 2024 •

edited

Loading

codecov bot commented Jan 23, 2024 •

edited

Loading