feat: address account nonce discrepancies mono

[natanasow]

Description:

Introduce clear rules for when to update an Ethereum transaction signer's nonce and a new field for externalising the nonce update in the record stream. This will help resolve issues where the Consensus nodes and the Mirror nodes are out of sync in regards to what the current value of an account's nonce is.

Specification:

1. The nonce of a signer of an Ethereum transaction should be increased for all transactions that are executed in the EVM.
2. Transactions that have reached consensus and are handled by the node but have failed additional validations performed by the node prior to being executed in the EVM should have no effect on the Ethereum transaction signer nonce.
3. A new protobuf field in the record stream - signerNonce - should be populated by the node with the current value of the signer account nonce after executing the transaction. This value should be used by the Mirror nodes when importing record stream files.

Protobuf update:

Add a new protobuf field to contract_call_local.proto:

message ContractFunctionResult {
    
    [...]

    /**
     * If not null this field specifies what the value of the signer account nonce is post transaction execution. 
     * For transactions that don't update the signer nonce, this field should be null.
     */
    Int64Value signer_nonce = 15;
}

Services update:

1. Move the signer nonce update to be right before this code block that starts the EVM:
2. Populate the new protobuf field when externalizing the transaction.

Fixes: #9728

Notes for reviewer:

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[github-actions]

Node: HAPI Test (Restart) Results

1 tests   1 ✔️  7m 4s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Node Death Reconnect) Results

1 tests   1 ✔️  7m 34s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Token) Results

189 tests   189 ✔️  19m 56s ⏱️
  13 suites      0 💤
  13 files        0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Crypto) Results

211 tests   211 ✔️  30m 10s ⏱️
  22 suites      0 💤
  22 files        0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

[github-actions]

Node: E2E Test Results

    1 files      1 suites   24m 40s ⏱️
311 tests 311 ✔️ 0 💤 0 ❌
333 runs  333 ✔️ 0 💤 0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

[github-actions]

Node: Unit Test Results

    2 285 files  ±  0      2 285 suites  ±0   2h 34m 19s ⏱️ - 2h 12m 46s
118 512 tests +30  118 458 ✔️ +30  54 💤 ±0  0 ❌ ±0 
127 029 runs  +30  126 975 ✔️ +30  54 💤 ±0  0 ❌ ±0 

Results for commit dbb8b4e. ± Comparison against base commit 2258784.

♻️ This comment has been updated with latest results.

[codecov]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (8bda7b2) 62.99% compared to head (773113f) 62.99%.
Report is 2 commits behind head on develop.

Files	Patch %	Lines
.../app/service/mono/state/submerkle/EvmFnResult.java	73.33%	1 Missing and 3 partials ⚠️
...ce/mono/txns/ethereum/EthereumTransitionLogic.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop   #11045      +/-   ##
=============================================
- Coverage      62.99%   62.99%   -0.01%     
- Complexity     31082    31088       +6     
=============================================
  Files           3362     3363       +1     
  Lines         137674   137708      +34     
  Branches       14479    14479              
=============================================
+ Hits           86728    86746      +18     
- Misses         47248    47261      +13     
- Partials        3698     3701       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Node: HAPI Test (Misc) Results

430 tests   416 ✔️  47m 23s ⏱️
  74 suites    14 💤
  74 files        0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Smart Contract) Results

451 tests   448 ✔️  1h 10m 54s ⏱️
  52 suites      3 💤
  52 files        0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

[github-actions]

Node: HAPI Test (Time Consuming) Results

20 tests   20 ✔️  54m 10s ⏱️
  2 suites    0 💤
  2 files      0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

[github-actions]

Node: Integration Test Results

    5 files      5 suites   1h 5m 42s ⏱️
319 tests 319 ✔️ 0 💤 0 ❌
331 runs  331 ✔️ 0 💤 0 ❌

Results for commit dbb8b4e.

♻️ This comment has been updated with latest results.

[stoqnkpL]

LGTM

[tinker-michaelj]

The nonce of a signer of an Ethereum transaction should be increased for all transactions that are executed in the EVM.

What counts as "executed in the EVM"? As long as we could charge gas, it counts?

[natanasow]

The nonce of a signer of an Ethereum transaction should be increased for all transactions that are executed in the EVM.

What counts as "executed in the EVM"? As long as we could charge gas, it counts?

IMO "executed in the EVM" means that the transaction has reached that point and there are no other "blockers". The last validations between prechecks and "evm execution" is here. So, once the transaction reaches that point, we are safe to increase the signer's nonce because there are no other potential validations that could lead to increasing the nonce and not executing the transaction like it was before.
The previous implementation increases the nonce here which causes a nonce discrepancy between services and mirror node because if the transaction fails in any of these checks, the nonce in services will be incremented but no record file will be exported and the new signer's nonce will not be populated in the mirror node.
These are my thoughts and feel free to correct me if I misunderstood something of that.

[codecov-commenter]

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2258784) 62.97% compared to head (dbb8b4e) 62.98%.

Files	Patch %	Lines
.../app/service/mono/state/submerkle/EvmFnResult.java	73.33%	1 Missing and 3 partials ⚠️
...ce/mono/txns/ethereum/EthereumTransitionLogic.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             develop   #11045   +/-   ##
==========================================
  Coverage      62.97%   62.98%           
- Complexity     31080    31090   +10     
==========================================
  Files           3369     3369           
  Lines         137783   137802   +19     
  Branches       14460    14464    +4     
==========================================
+ Hits           86768    86788   +20     
- Misses         47312    47313    +1     
+ Partials        3703     3701    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tinker-michaelj]

LGTM, tyvm @natanasow !