-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update local-node Docker images to Java 21 (cherry pick #10834) #10968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iliya Savov <[email protected]>
Signed-off-by: Iliya Savov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.46 #10968 +/- ##
==================================================
- Coverage 62.79% 62.78% -0.01%
Complexity 31004 31004
==================================================
Files 3384 3384
Lines 136912 136912
Branches 14307 14307
==================================================
- Hits 85975 85966 -9
- Misses 47495 47501 +6
- Partials 3442 3445 +3 ☔ View full report in Codecov by Sentry. |
nathanklick
approved these changes
Jan 16, 2024
isavov
changed the title
chore: cherry pick #10834
chore: Update local-node Docker images to Java 21 (cherry pick #10834)
Jan 16, 2024
Neeharika-Sompalli
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR cherry picks an update to
Dockerfile
definitions forlocal-node
images ofhedera-services
to facilitate the migration to Java 21 and fix broken local node images for the 0.46 release.Cherry pick #10834
Related issue(s):
Fixes #10833
Notes for reviewer:
Checklist