Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update local-node Docker images to Java 21 (cherry pick #10834) #10968

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

isavov
Copy link
Contributor

@isavov isavov commented Jan 15, 2024

Description:
This PR cherry picks an update to Dockerfile definitions for local-node images of hedera-services to facilitate the migration to Java 21 and fix broken local node images for the 0.46 release.

Cherry pick #10834

Related issue(s):

Fixes #10833

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@isavov isavov requested review from Nana-EC and stoqnkpL January 15, 2024 11:14
@isavov isavov self-assigned this Jan 15, 2024
@isavov isavov marked this pull request as ready for review January 15, 2024 11:24
@isavov isavov requested review from a team as code owners January 15, 2024 11:24
@isavov isavov requested a review from a team January 15, 2024 11:24
@isavov isavov requested a review from a team as a code owner January 15, 2024 11:24
Copy link

Node: HAPI Test (Token) Results

189 tests  ±0   189 ✔️ ±0   16m 15s ⏱️ -55s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ±0 

Results for commit 012062a. ± Comparison against base commit a0e1585.

Copy link

Node: HAPI Test (Crypto) Results

211 tests  ±0   208 ✔️ ±0   17m 51s ⏱️ +18s
  22 suites ±0       3 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit 012062a. ± Comparison against base commit a0e1585.

Copy link

Node: E2E Test Results

    1 files  ±    0      1 suites  ±0   22m 55s ⏱️ + 22m 55s
311 tests +310  311 ✔️ +311  0 💤 ±0  0  - 1 
333 runs  +332  333 ✔️ +333  0 💤 ±0  0  - 1 

Results for commit 012062a. ± Comparison against base commit a0e1585.

Copy link

Node: Unit Test Results

    2 294 files  ±0      2 294 suites  ±0   49m 13s ⏱️ - 15m 12s
118 681 tests ±0  118 646 ✔️ ±0  35 💤 ±0  0 ±0 
127 098 runs  ±0  127 063 ✔️ ±0  35 💤 ±0  0 ±0 

Results for commit 012062a. ± Comparison against base commit a0e1585.

Copy link

Node: HAPI Test (Misc) Results

383 tests  ±0   323 ✔️ ±0   24m 16s ⏱️ +10s
  72 suites ±0     60 💤 ±0 
  72 files   ±0       0 ±0 

Results for commit 012062a. ± Comparison against base commit a0e1585.

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0e1585) 62.79% compared to head (012062a) 62.78%.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/0.46   #10968      +/-   ##
==================================================
- Coverage           62.79%   62.78%   -0.01%     
  Complexity          31004    31004              
==================================================
  Files                3384     3384              
  Lines              136912   136912              
  Branches            14307    14307              
==================================================
- Hits                85975    85966       -9     
- Misses              47495    47501       +6     
- Partials             3442     3445       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Node: HAPI Test (Time Consuming) Results

20 tests  ±0   17 ✔️ ±0   45m 10s ⏱️ +3s
  2 suites ±0     3 💤 ±0 
  2 files   ±0     0 ±0 

Results for commit 012062a. ± Comparison against base commit a0e1585.

Copy link

Node: HAPI Test (Smart Contract) Results

444 tests  ±0   435 ✔️ ±0   52m 42s ⏱️ - 2m 24s
  52 suites ±0       9 💤 ±0 
  52 files   ±0       0 ±0 

Results for commit 012062a. ± Comparison against base commit a0e1585.

Copy link

Node: Integration Test Results

    5 files  ±0      5 suites  ±0   1h 5m 43s ⏱️ +22s
312 tests ±0  312 ✔️ ±0  0 💤 ±0  0 ±0 
314 runs  ±0  314 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 012062a. ± Comparison against base commit a0e1585.

@isavov isavov changed the title chore: cherry pick #10834 chore: Update local-node Docker images to Java 21 (cherry pick #10834) Jan 16, 2024
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@nathanklick nathanklick merged commit e4c1022 into release/0.46 Jan 16, 2024
59 checks passed
@nathanklick nathanklick deleted the cherry-pick-10833 branch January 16, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants