fix: (mod-service)Use concurrent read cache #10965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Tinker <[email protected]>
Neeharika-Sompalli
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #10965 +/- ##
=============================================
+ Coverage 63.26% 63.27% +0.01%
- Complexity 31301 31315 +14
=============================================
Files 3390 3390
Lines 137447 137483 +36
Branches 14405 14405
=============================================
+ Hits 86951 86996 +45
+ Misses 46906 46901 -5
+ Partials 3590 3586 -4 ☔ View full report in Codecov by Sentry. |
Node: E2E Test Results 1 files ± 0 1 suites ±0 23m 54s ⏱️ + 23m 54s Results for commit fa478b2. ± Comparison against base commit cca3e1c. This pull request removes 1 and adds 311 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
tinker-michaelj
approved these changes
Jan 13, 2024
timo0
pushed a commit
that referenced
this pull request
Jan 22, 2024
Signed-off-by: Michael Tinker <[email protected]> Co-authored-by: Michael Tinker <[email protected]> Signed-off-by: Timo Brandstätter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause is the use of a HashMap readCache in ReadableKVStateBase results a race between (1) thread A that is trying to get an already-read key and (2) thread B that is trying to add a newly-read key and hence resizing the HashMap. This can lead to ISS.
To solve the issue used
ConcurrentHashMaporSynchronizedMapinstead ofHashMapfor readCache. Since we want to store null values in readCache if the entity doesn't exist in state, andConcurrentHashMapdoesn't allow null values decided to useSynchronizedMap.This will be changed to use a Marker object instead of null value in the future based on performance testing.