Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support restarting from RECORDS -> BOTH #15904

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: support restarting from RECORDS -> BOTH #15904

wants to merge 3 commits into from
+88 −122

Conversation

tinker-michaelj
Copy link
Collaborator

@tinker-michaelj tinker-michaelj requested review from a team as code owners October 8, 2024 00:07
@tinker-michaelj tinker-michaelj added this to the v0.56 milestone Oct 8, 2024
@tinker-michaelj tinker-michaelj self-assigned this Oct 8, 2024
@tinker-michaelj
Revert version.txt change
899f8cf 
Signed-off-by: Michael Tinker <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.14%. Comparing base (debdc9a) to head (4f9d92d).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...en/impl/handlers/staking/StakingRewardsHelper.java 85.71% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #15904      +/-   ##
=============================================
- Coverage      58.14%   58.14%   -0.01%     
- Complexity     21633    21635       +2     
=============================================
  Files           2786     2788       +2     
  Lines         109604   109665      +61     
  Branches       11215    11224       +9     
=============================================
+ Hits           63733    63766      +33     
- Misses         41995    42019      +24     
- Partials        3876     3880       +4
Files with missing lines Coverage Δ
...-app/src/main/java/com/hedera/node/app/Hedera.java 11.50% <100.00%> (ø)
...com/hedera/node/app/blocks/BlockStreamService.java 53.84% <100.00%> (-14.91%) ⬇️
...a/node/app/blocks/impl/BlockStreamManagerImpl.java 97.52% <ø> (ø)
...ode/app/blocks/schemas/V0560BlockStreamSchema.java 100.00% <100.00%> (ø)
...om/hedera/node/app/records/BlockRecordService.java 100.00% <100.00%> (ø)
...de/app/records/schemas/V0560BlockRecordSchema.java 100.00% <100.00%> (ø)
...ava/com/hedera/node/config/data/StakingConfig.java 100.00% <ø> (ø)
...en/impl/handlers/staking/StakingRewardsHelper.java 94.17% <85.71%> (-1.66%) ⬇️

... and 23 files with indirect coverage changes

Impacted file tree graph

@codacy-production Codacy Production
Copy link

codacy-production bot commented Oct 8, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.00% (target: -1.00%) ✅ 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (debdc9a) 109421 67499 61.69%
Head commit (4f9d92d) 109475 (+54) 67534 (+35) 61.69% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15904) 21 21 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

derektriley
derektriley approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@derektriley derektriley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although I can't load/see the new Codacy issues.

@andrewb1269hg
Copy link

Please review the Codacy findings before merging.

@mhess-swl
Copy link
Member

Please review the Codacy findings before merging.

Codacy hasn't yet been tuned to a useful rule set. It frequently complains about issues that aren't issues. I'm not sure why it's running at all at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derektriley derektriley derektriley approved these changes

@petreze petreze petreze approved these changes

@jasperpotts jasperpotts Awaiting requested review from jasperpotts jasperpotts is a code owner automatically assigned from hashgraph/hedera-base

@kimbor kimbor Awaiting requested review from kimbor kimbor is a code owner automatically assigned from hashgraph/hedera-services

@andrewb1269hg andrewb1269hg Awaiting requested review from andrewb1269hg andrewb1269hg was automatically assigned from hashgraph/devops-ci

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy was automatically assigned from hashgraph/release-engineering-managers

Assignees

@tinker-michaelj tinker-michaelj

Labels
None yet
Projects
None yet
Milestone
v0.56
Development

Successfully merging this pull request may close these issues.

BlockStreamInfo migration logic needs to run in a Schema of the latest version
5 participants
@tinker-michaelj @andrewb1269hg @mhess-swl @derektriley @petreze