feat(accountCreateTransaction): Implement AccountCreateTransaction E2E tests: TCK
#206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to use as a model going forward. Create utility.md file to hold miscellaneous JSON RPC functions. Move tests and test specifictions documents to folders for the specific Hedera service they are for Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…ion is now contained in accountCreateTransaction.md Signed-off-by: Rob Walworth <[email protected]>
…ix alias only being able to be an ECDSAsecp256k1 key. Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…ts for receiver signature required, auto renew period, and memo Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…-tests-tck Signed-off-by: Rob Walworth <[email protected]>
…tests as implemented Signed-off-by: Rob Walworth <[email protected]>
rwalworth
requested review from
SimiHunjan,
0xivanov,
RickyLB,
agadzhalov,
Petyo-Lukanov,
svetoslav-nikol0v and
gsstoykov
… tests for declineStakingRewards. Some generateKey calls didn't have a type when they should. Signed-off-by: Rob Walworth <[email protected]>
…t variable name for maxAutoTokenAssociations. Use correct bounds for maxAutoTokenAssociations Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
…local node testing Signed-off-by: Rob Walworth <[email protected]>
…-tests-tck Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
gsstoykov
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Regarding test-specifications/crypto-service/ can we think of a better name than crypto-service here? From my perspective this is not that appropriate. Will it be better to have more specific test specification folders like test-specifications/account, test-specifications/contract and etc?
Sure, the initial idea was to organize request tests into the Hedera service to which that request was handled (i.e. |
… maximum auto token associations The functionality for this will need to be removed when HIP-904 is implemented, as that will make the sender pay at transaction time for the association of a token to a receiver, as opposed to the receiver paying up front at account creation time for all its token assocations. Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
2 tasks
0xivanov
reviewed
Jul 4, 2024
0xivanov
reviewed
Jul 4, 2024
Signed-off-by: Rob Walworth <[email protected]>
…create Signed-off-by: Rob Walworth <[email protected]>
thenswan
reviewed
Jul 22, 2024
0xivanov
reviewed
Jul 23, 2024
Signed-off-by: Rob Walworth <[email protected]>
2 tasks
…ciation changes as that was moved to v0.53 Signed-off-by: Rob Walworth <[email protected]>
Signed-off-by: Rob Walworth <[email protected]>
0xivanov
approved these changes
Aug 2, 2024
rwalworth
deleted the
00205-implement-accountcreatetransaction-e2e-tests-tck
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the tests documented in
test-specfications/crypto-service/accountCreateTransaction.md. Since some of the work was already done forAccountCreateTransactiontests, this reworks those tests to match what is in the test specifications, in addition to adding any new tests. The docs were also updated to mark the tests as implemented.Reminder, according to the development process we have established for the TCK (#202), this SHOULD NOT be approved by an SDK lead until their SDK has done any development required to run these tests against their SDK and those tests have passed. Feel free to provide comments and input to the PR, but approvals should not be granted until testing has occurred.
Issues opened in SDKs that encompass the SDK server work should be linked back to the TCK's
AccountCreateTransactiondevelopment issue (#36) for easy tracking.Note: This PR contains respective code changes for #209 and #211. If those change, this PR will change.
Related issue(s):
Fixes #205
Checklist