Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin exact Java version #2145

Merged
merged 2 commits into from
Dec 18, 2024
Merged

ci: pin exact Java version #2145

merged 2 commits into from
Dec 18, 2024

Conversation

jjohannes
Copy link
Contributor

Description:

This is important for deterministic and reproducible builds. Without this, the version automatically changes when there is a new release.

@jjohannes jjohannes self-assigned this Dec 16, 2024
@jjohannes jjohannes requested review from a team as code owners December 16, 2024 13:20
This is important for deterministic and reproducible builds.
Without this, the version automatically changes when there is a new
release.

Signed-off-by: Jendrik Johannes <[email protected]>
Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious about this java version, should we not be building against the latest?

.github/workflows/build.yml Show resolved Hide resolved
@jjohannes jjohannes requested a review from rbarkerSL December 18, 2024 16:08
@jjohannes jjohannes merged commit 83119fb into main Dec 18, 2024
7 checks passed
@jjohannes jjohannes deleted the pin-java-version branch December 18, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants