feat(ContractFunctionParameters): adds addBytes4 and addBytes4Array #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ph#2022) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jeffery Orazulike <[email protected]>
Signed-off-by: Jeffery Orazulike <[email protected]>
logickoder
force-pushed
the
1650-addBytes4
branch
from
b10913d
to
267b6af
Compare
logickoder
changed the title
0xivanov
reviewed
Oct 7, 2024
...ava/com/hedera/hashgraph/sdk/test/integration/ContractFunctionParametersIntegrationTest.java
Outdated
Show resolved
Hide resolved
0xivanov
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Hey, nice work!
DCO check is failing because the commits are not signed off. Please check out https://github.com/hashgraph/.github/blob/main/CONTRIBUTING.md and see how to set up your GPG keys.
When you've setup the keys you can rebase your commits while signing them.
https://stackoverflow.com/questions/13043357/git-sign-off-previous-commits
Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ivan Ivanov <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Roger Barker <[email protected]> Co-authored-by: Ivan Ivanov <[email protected]> Signed-off-by: Jeffery Orazulike <[email protected]>
…n from 2.0.2 to 2.1.4 in /gradle/plugins (hashgraph#2028) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jeffery Orazulike <[email protected]>
…ing (hashgraph#1930) Signed-off-by: Matt Riben <[email protected]> Signed-off-by: Ivan Ivanov <[email protected]> Co-authored-by: Ivan Ivanov <[email protected]> Signed-off-by: Jeffery Orazulike <[email protected]>
…ashgraph#2023) Signed-off-by: steffenboe <[email protected]> Co-authored-by: Ivan Ivanov <[email protected]> Signed-off-by: Jeffery Orazulike <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ivan Ivanov <[email protected]> Signed-off-by: Jeffery Orazulike <[email protected]>
|
@0xivanov done |
Hmm there are still not verified commits, I will try to sign them off for you. Are you Ok with that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
adds addBytes4 and addBytes4Array to ContractFunctionParameters class
Related issue(s):
Fixes #
addBytes4()method toContractFunctionParameters#1650Notes for reviewer:
Checklist