Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set adressBook and remove overloaded method #2024

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

steffenboe
Copy link
Contributor

Description:
This PR sets client information in the Client method setNetworkFromAddressBook() by default and removes the overloaded method.

Related issue(s):
#2015

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@steffenboe steffenboe requested a review from a team as a code owner October 4, 2024 21:52
@steffenboe steffenboe force-pushed the 2015_setNetworkFromAdressBook branch 2 times, most recently from 28293ab to e90a7a5 Compare October 4, 2024 21:56
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged next milestone.

@steffenboe steffenboe force-pushed the 2015_setNetworkFromAdressBook branch from 771138e to 582f0b8 Compare October 7, 2024 18:54
Signed-off-by: steffenboe <[email protected]>

Fix javadoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants