Make testEnv implement Autoclosable Interface, replace occurrences

[steffenboe]

Description:
Makes IntegrationTestEnv implement Autoclosable and replaces occurrences in tests with try-with-resources-block.

Related issue(s):

Fixes #
#1975

Notes for reviewer:

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[steffenboe]

need to take a look at the indentation changes yet, so i switched this PR to WIP

[steffenboe]

ready for review!

[0xivanov]

Hey, nice work!
DCO check is failing because the commits are not signed off. Please check out https://github.com/hashgraph/.github/blob/main/CONTRIBUTING.md and see how to set up your GPG keys.
When you've setup the keys you can rebase your commits while signing them.
https://github.com/hashgraph/hedera-sdk-java/pull/2023/checks?check_run_id=31080572033

[0xivanov]

Looks good, there are some usages missing thought, like in TokenGrantKycIntegrationTest and TransactionResponseTest

[steffenboe]

you're correct, and these tests aren't the only ones where a replacement is not possible. this is because the close()-method gets called with parameters there. this is not conforming to the Autoclosable interface, and so these occurrences can't be replaced with a try-with-resources block.

[0xivanov]

@steffenboe You are right, I had forgotten about that! I was actually thinking a while back to rework the close method to not have overloads and remove the wiping logic wipeAccountHbars(newAccountId, newAccountKey); . This additional logic is making the github action slow and we don't need it since the operator we are using in the local-node has 10k HBARs which should be enough.

Would you like to rework the close method to look something like this? :

    public void close() throws Exception {
        if (!operatorId.equals(originalClient.getOperatorAccountId())) {
            var hbarsBalance = new AccountBalanceQuery()
                .setAccountId(operatorId)
                .execute(originalClient)
                .hbars;
            new TransferTransaction()
                .addHbarTransfer(operatorId, hbarsBalance.negated())
                .addHbarTransfer(Objects.requireNonNull(originalClient.getOperatorAccountId()), hbarsBalance)
                .freezeWith(originalClient)
                .signWithOperator(client)
                .execute(originalClient);
            client.close();
        }

        originalClient.close();
    }

And then you could finish the rest of the tests to use try-with-resources.

[steffenboe]

Sounds good! Will work on that ;)

[0xivanov]

LGTM, TY @steffenboe