Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some Android compatibility issues #1638

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Conversation

thenswan
Copy link
Contributor

Description:
Fixed some Android compatibility issues (related to the support of the futures).

Related issue(s):
Fixes #1606

Notes for reviewer:

  • Reverts some part of this commit (bringing back streamsupport-cfuture)
  • Reverts this commit (because it is not relevant with streamsupport-cfuture)

@thenswan thenswan requested a review from rokn October 23, 2023 11:56
@thenswan thenswan requested a review from SimiHunjan as a code owner October 23, 2023 11:56
Signed-off-by: Nikita Lebedev <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4059ab9) 82.23% compared to head (21dcd32) 82.21%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1638      +/-   ##
=============================================
- Coverage      82.23%   82.21%   -0.02%     
+ Complexity      3589     3586       -3     
=============================================
  Files            186      186              
  Lines          11697    11692       -5     
  Branches        1148     1148              
=============================================
- Hits            9619     9613       -6     
  Misses          1602     1602              
- Partials         476      477       +1     
Files Coverage Δ
...java/com/hedera/hashgraph/sdk/AccountInfoFlow.java 72.72% <ø> (ø)
...ava/com/hedera/hashgraph/sdk/AccountInfoQuery.java 70.00% <ø> (ø)
...ava/com/hedera/hashgraph/sdk/AddressBookQuery.java 82.35% <ø> (ø)
...c/main/java/com/hedera/hashgraph/sdk/BaseNode.java 83.51% <ø> (ø)
...a/com/hedera/hashgraph/sdk/ChunkedTransaction.java 74.49% <ø> (ø)
...src/main/java/com/hedera/hashgraph/sdk/Client.java 81.28% <100.00%> (ø)
.../java/com/hedera/hashgraph/sdk/ConsumerHelper.java 88.88% <ø> (ø)
...va/com/hedera/hashgraph/sdk/ContractCallQuery.java 73.33% <ø> (ø)
...a/com/hedera/hashgraph/sdk/ContractCreateFlow.java 67.51% <ø> (ø)
...va/com/hedera/hashgraph/sdk/ContractInfoQuery.java 70.00% <ø> (ø)
... and 14 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thenswan thenswan merged commit 7ffc434 into develop Oct 24, 2023
7 of 8 checks passed
@thenswan thenswan deleted the 1606-android-issue branch October 24, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes Getting exception when creating client object
2 participants