Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add auto-renew account support for files and accounts #1228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dikel
Copy link
Contributor

@dikel dikel commented Nov 4, 2022

Signed-off-by: dikel [email protected]

Description:

  • Update protobufs
  • add autoRenewAccountId to Account[Create|Update|Info]Transaction and File[Create|Update|Info]Transaction

Related issue(s):

Fixes #1218
Fixes #1219
Fixes #1220
Fixes #1221
Fixes #1222
Fixes #1223

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

84.1% 84.1% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 71.74% // Head: 71.76% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (4ab0464) compared to base (a491695).
Patch coverage: 76.59% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1228      +/-   ##
=============================================
+ Coverage      71.74%   71.76%   +0.02%     
- Complexity      2660     2668       +8     
=============================================
  Files            184      184              
  Lines          11336    11381      +45     
  Branches        1113     1123      +10     
=============================================
+ Hits            8133     8168      +35     
- Misses          2555     2559       +4     
- Partials         648      654       +6     
Impacted Files Coverage Δ
...ain/java/com/hedera/hashgraph/sdk/AccountInfo.java 89.56% <66.66%> (-0.44%) ⬇️
...hedera/hashgraph/sdk/AccountUpdateTransaction.java 55.97% <66.66%> (+0.64%) ⬆️
...om/hedera/hashgraph/sdk/FileUpdateTransaction.java 61.44% <66.66%> (+0.63%) ⬆️
...c/main/java/com/hedera/hashgraph/sdk/FileInfo.java 93.87% <83.33%> (-1.58%) ⬇️
...om/hedera/hashgraph/sdk/FileCreateTransaction.java 80.59% <87.50%> (+0.93%) ⬆️
...hedera/hashgraph/sdk/AccountCreateTransaction.java 78.35% <88.88%> (+0.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants