Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow maxAutomaticTokenAssociations values to be -1 #723

Merged
merged 7 commits into from
Jul 16, 2024
Merged

feat: allow maxAutomaticTokenAssociations values to be -1 #723

merged 7 commits into from
Jul 16, 2024

Conversation

rwalworth
Copy link
Contributor

@rwalworth rwalworth commented Jun 18, 2024 •
edited
Loading

This PR updates any and all maxAutomaticTokenAssociations variable for accounts and contracts to be -1. Tests were also added to verify correct functionality.

Related issue(s):

Fixes #709 #710 #720

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@rwalworth rwalworth added the Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Jun 18, 2024
@rwalworth rwalworth self-assigned this Jun 18, 2024
@rwalworth rwalworth requested review from a team as code owners June 18, 2024 20:03
@rwalworth rwalworth requested a review from gsstoykov June 18, 2024 20:03
@rwalworth rwalworth linked an issue Jun 18, 2024 that may be closed by this pull request
Update HIP-904: AccountCreateTransaction to allow maxAutomaticTokenAssociations value to support -1 as a valid value #709
Closed
@rwalworth rwalworth requested review from a team as code owners June 20, 2024 14:23
jeromy-cannon
jeromy-cannon previously approved these changes Jun 20, 2024
View reviewed changes
@rwalworth
Copy link
Contributor Author

This is waiting to be tested until services v0.52, which allows maxAutoTokenAssociations to be -1, is tagged and available for testing.

gsstoykov
gsstoykov reviewed Jul 4, 2024
View reviewed changes
Copy link
Contributor

@gsstoykov gsstoykov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the local-node version in CI but the tests are still failing due to missing proto definitions from v0.52.0.

jeromy-cannon
jeromy-cannon previously approved these changes Jul 8, 2024
View reviewed changes
@rwalworth
Merge branch 'main' into 00709-update-hip-904-accountcreatetransactio…
e92a4bc 
…n-to-allow-maxautomatictokenassociations-value-to-support-1-as-a-valid-value
@rwalworth
Copy link
Contributor Author

This has been tested with v0.52.0-alpha.6 version of hedera-services which contain the max auto association changes, so this should be good to review again.

gsstoykov
gsstoykov previously approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

jeromy-cannon
jeromy-cannon previously approved these changes Jul 16, 2024
View reviewed changes
@rwalworth rwalworth dismissed stale reviews from jeromy-cannon and gsstoykov via 29aabaf July 16, 2024 13:56
gsstoykov
gsstoykov approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rwalworth rwalworth merged commit 1dc458f into main Jul 16, 2024
2 checks passed
@rwalworth rwalworth deleted the 00709-update-hip-904-accountcreatetransaction-to-allow-maxautomatictokenassociations-value-to-support-1-as-a-valid-value branch July 16, 2024 15:35
@rwalworth rwalworth mentioned this pull request Jul 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromy-cannon jeromy-cannon jeromy-cannon approved these changes

@gsstoykov gsstoykov gsstoykov approved these changes

@matteriben matteriben Awaiting requested review from matteriben matteriben is a code owner automatically assigned from hashgraph/release-engineering

Assignees

@rwalworth rwalworth

Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
None yet
Milestone
No milestone
3 participants
@rwalworth @jeromy-cannon @gsstoykov