Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a bool field to allow fractional fee to be charged to sender or receiver. #82

Closed
wants to merge 2 commits into from
Closed

Add a bool field to allow fractional fee to be charged to sender or receiver. #82

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
833cb60
Add a bool field to allow fractional fee charged to sender or receiver.
ljianghedera Aug 4, 2021
67f5113
Changes per review comments.
ljianghedera Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/proto/CustomFees.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ message FractionalFee {
Fraction fractional_amount = 1; // The fraction of the transferred units to assess as a fee
int64 minimum_amount = 2; // The minimum amount to assess
int64 maximum_amount = 3; // The maximum amount to assess (zero implies no maximum)
bool netOfTransfers = 4; // If true, assesses the fee to the sender, so the receiver gets the full amount from the token transfer list, and the sender is charged an additional fee; if false, the receiver does NOT get the full amount, but only what is left over after paying the fractional fee
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snake_case, for consistency

}

/* A fixed number of units (hbar or token) to assess as a fee during a CryptoTransfer
Expand Down