-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix address book duplicate entries #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a new type NodeAddressNodeAddressAbbreviated to allow backward compatibility Signed-off-by: anighanta <[email protected]>
Signed-off-by: anighanta <[email protected]>
Signed-off-by: anighanta <[email protected]>
Signed-off-by: anighanta <[email protected]>
…eviated to NodeAddressForClients and NodeAddressBookAbbreviated to AddressBookForClients
… comment udpates Signed-off-by: anighanta <[email protected]>
Signed-off-by: anighanta <[email protected]>
anighanta
requested review from
tinker-michaelj,
Neeharika-Sompalli,
ljianghedera,
qnswirlds and
steven-sheehy
March 31, 2021 18:33
steven-sheehy
previously approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ljianghedera
previously approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
qnswirlds
previously approved these changes
Mar 31, 2021
Signed-off-by: anighanta <[email protected]>
anighanta
dismissed stale reviews from qnswirlds, ljianghedera, and steven-sheehy
via
March 31, 2021 21:30
6d92bcd
tinker-michaelj
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue : #60
Followed changes in hashgraph/hedera-protobufs#22
according to issue : hashgraph/hedera-services#750